Allow custom package comments #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
robmen
requested changes
Apr 24, 2023
mosBrkr
force-pushed
the
feature/allow-custom-package-comments
branch
from
f379b72
to
b5f5abf
Compare
robmen
requested changes
Apr 25, 2023
src/wix/test/WixToolsetTest.CoreIntegration/TestData/Comments/Default.wxs
Outdated
Show resolved
Hide resolved
|
PS: Something is up with the CLA bot. I'll investigate that independently. |
mosBrkr
force-pushed
the
feature/allow-custom-package-comments
branch
from
b5f5abf
to
f2c7bb1
Compare
|
@robmen Can I support you somehow with the CLA bot issue? |
|
recheck |
robmen
approved these changes
Jul 19, 2023
Fixes #7369
robmen
force-pushed
the
feature/allow-custom-package-comments
branch
from
f2c7bb1
to
95bf601
Compare
|
Thanks. Sorry, I got busy and didn't get this finished earlier. I just had to rebase it one more time then the CLA-Bot finally started passing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7369