Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Ledger Live #1060

Open
darosior opened this issue Mar 28, 2024 · 6 comments
Open

Avoid Ledger Live #1060

darosior opened this issue Mar 28, 2024 · 6 comments
Labels
Feature New feature or functionality. In discussion Not ready for implementation. It is still being discussed whether we should address this issue. Nice to have If it's not completed in time for the current version, it can be postponed RFC Needs conceptual discussion and/or feedback from users

Comments

@darosior
Copy link
Member

Having to use Ledger Live is one of the major pain points for our users. In my opinion the Ledger Nano S+ is a great device, which i recommend to beginners on Liana. Besides the flaws of the company itself, when i bring this up to someone their reaction is "err but it means i need to use Ledger Live, i'm not using that".

It's really unfortunate that the experience of our users is severely affected by an unreliable software out of our control. Especially since on Liana Lite the Ledger is the only signing device we support for now. This issue is to track an effort to get rid of this requirement on our users to go through Ledger Live.

As of now, what does the user need Ledger Live for?

  • Initial setup of the Ledger
  • Bitcoin app installation
  • Firmware upgrade
  • Bitcoin app upgrade

Ledger Live is an open source software, so we must be able to query the Ledger servers just like it does and install the firmware? Am i missing something? Is it actually doing nontrivial things which would be hard to replicate? We need to investigate.

@darosior darosior added RFC Needs conceptual discussion and/or feedback from users Feature New feature or functionality. In discussion Not ready for implementation. It is still being discussed whether we should address this issue. labels Mar 28, 2024
@darosior darosior moved this to Nice to have in Liana v6 Mar 28, 2024
@kallerosenbaum
Copy link

kallerosenbaum commented Mar 28, 2024

There's some APDU docs here: https://github.com/LedgerHQ/app-bitcoin-new/blob/master/doc/bitcoin.md
And a javascript library to communicate with the bitcoin app is here: https://github.com/LedgerHQ/ledger-live/tree/develop/libs/ledgerjs/packages/hw-app-btc

I was involved implementing the javascript lib.

Edit: I see, you were talking about the setup/upgrade stuff, which is not covered by this library.

@pythcoiner
Copy link
Collaborator

@achow101 have already retro-engineered the thing (Thanks!):

gist

python script

@jp1ac4 also notice this can be helpfull:

ledger gist

@darosior
Copy link
Member Author

darosior commented Apr 1, 2024

I've implemented a PoC over the weekend: https://github.com/darosior/ledger_installer. It can perform the genuine check and install the Bitcoin app (and also open it). It needs to get cleaned up but we can already pull some bits in the GUI i think.

@pythcoiner
Copy link
Collaborator

just implemented draft gui:

https://github.com/pythcoiner/ledger_installer_gui

@darosior
Copy link
Member Author

darosior commented Apr 1, 2024

Here is the current onboarding process of Ledger Live as of version 2.77.2. Thanks Kevin!

Screencast.from.2024-04-01.11-09-55.webm

@nondiremanuel nondiremanuel moved this to Nice to have in Liana General Jun 11, 2024
@nondiremanuel nondiremanuel removed this from Liana v6 Jun 11, 2024
@nondiremanuel nondiremanuel added the Nice to have If it's not completed in time for the current version, it can be postponed label Jun 19, 2024
@nondiremanuel nondiremanuel added this to the Liana v7 milestone Jun 25, 2024
@nondiremanuel
Copy link
Collaborator

First step in this direction should be represented by #1135 for Bitcoin app upgrade

@nondiremanuel nondiremanuel modified the milestones: v7 - Liana, v8 - Liana Jul 19, 2024
@nondiremanuel nondiremanuel removed this from the v9 Liana - Candidates milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or functionality. In discussion Not ready for implementation. It is still being discussed whether we should address this issue. Nice to have If it's not completed in time for the current version, it can be postponed RFC Needs conceptual discussion and/or feedback from users
Projects
None yet
Development

No branches or pull requests

4 participants