Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for creating a new wallet with remote participants #542

Closed
pythcoiner opened this issue May 29, 2023 · 4 comments
Closed

Improve UX for creating a new wallet with remote participants #542

pythcoiner opened this issue May 29, 2023 · 4 comments

Comments

@pythcoiner
Copy link
Collaborator

When you create a wallet importing Xpub from other remotes participants, it would be nice that after we already register one xpub (by example in the primary path) we can just have to 'select' the key in the signing devices list instead of paste its Xpub (maybe need to have a color scheme for differentiate hot/hardware/remote wallets?) .

here a quick example:
image
liana2 is my 'local' Liana hot key
liana3 is a remote (hot) key (i already import xpub in primary path)
liana4 is another remote (hot) key (i already import xpub in primary path)

when i add a key to the recovery path:
image
only liana2 is present in the signing device list (i think we need to display all the already imported key here)

@pythcoiner
Copy link
Collaborator Author

ok i think i got the point, because we cannot reuse the same derivation path (we cannot use twice the same xpub in the descriptor), but is it any way to derive only from a known Xpub (so that derivation can be done on the 'coordinator' side instead the remote guys need so send a batch of keys)?

@kloaec
Copy link
Collaborator

kloaec commented Jun 21, 2023

Great point. I just want to make sure we don't do anything stupid, but it seems perfectly doable, and a big improvement on the current UX for participants, and creator.

We would need to either to derive one more depth to have the different xpubs, or to have a way to "go back up" one step in the tree, to derive siblings to the first one.

We may want to get a (new) specific path for the xpub to be extracted/shared, to make sure one step higher isn't hardened if we go the siblings route.

Let's discuss this more, I think it's a very good ux improvement and should be implemented as soon as possible.

darosior added a commit that referenced this issue Jul 24, 2023
…derivation paths

28049d4 descriptor: make it possible to use the same xpub at different paths (Antoine Poinsot)

Pull request description:

  This is unnecessary to bump a hardened step to get another xpub for the same participant:
  - It's more hurdle when sharing it
  - It's more hurdle when verifying it on the device's screen
  - It's for the same person within the same script anyways

  Fix this by allowing to use the same xpub multiple times in a descriptor as long as the derivation path is different. Then the GUI will be able to use a new unhardened derivation step instead of bumping the BIP48 "accounts". A unit test is introduced that showcases this.

  See also #542.

ACKs for top commit:
  edouardparis:
    ACK 28049d4

Tree-SHA512: e864a8193998667d36b34d96e6e32bfff1c507b3c31faa324b7f264604c41b5d2d4aefeec3b71a1d3edf5b0242966861887baf97d7a410e43e7449f22c3453f4
@edouardparis
Copy link
Member

edouardparis commented Aug 17, 2023

I think it is done by #581 @darosior

@darosior
Copy link
Member

Yes indeed! Next time you should link it with using "Fixes #XXX" in the PR OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants