Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with EC 135 P2 and feature request #2

Open
HHS81 opened this issue Apr 26, 2020 · 7 comments
Open

Error with EC 135 P2 and feature request #2

HHS81 opened this issue Apr 26, 2020 · 7 comments

Comments

@HHS81
Copy link

HHS81 commented Apr 26, 2020

1.)I experienced some issue with EC 135 P2. Since other helicopters work- even the H135 which is based on the EC135 P2 and I do not see any difference, there is must be something I did wrong.

I got this error message, when I select an available load point:
Nasal runtime error: setprop() value is not string or number at , line 14
I wonder what I`m doing wrong?

2.)Nethertheless, adding every helicopter available for FGFS to the addon aircraft.xml is not the right thing I think.
Many helicopters in FGFS (YASim at least, maybe JSBSim) has hitches defined- for longlines and winches. They can be easily read out in sim/hitches - I think it will be better, if this will be used.
@wlbragg
Copy link
Owner

wlbragg commented Apr 26, 2020 •
edited
Loading

I experienced some issue with EC 135 P2. Since other helicopters work- even the H135 which is based on the EC135 P2 and I do not see any difference, there is must be something I did wrong.

No, some how missed it in the aircraft.xml definition. Once I push the changes it should load by default to the correct settings for an external winch on the right side.

Many helicopters in FGFS (YASim at least, maybe JSBSim) has hitches defined- for longlines and winches. They can be easily read out in sim/hitches

That is for aerotow, but I suppose it could play a part in the Cargo Towing Addon. Maybe it should. I'll look closely at that in the future.

But the way it is working right now is I actually read all the loadpoints and you have the option to use any of the existing load points, you can choose which one to use. I may be able to include the aerotow if it turns out it is a proper thing to do.

For example, the EC 135 P2 in fgaddon, freshly updated through the qt-launcher.

These are the FDM defined mass and weight points...

	<ballast x="-0.050" y="+0.0" z=" 0.528" mass="534.5"/>
	<ballast x="-6.346" y="+0.0" z=" 0.528" mass="534.5"/>
	
	<ballast x="-3.198" y="1.33" z=" 0.528" mass="534.5"/>
	<ballast x="-3.198" y="-1.33" z=" 0.528" mass="534.5"/>
	
	<ballast x="-3.198" y="+0.0" z="1.8438" mass="534.5"/>
	<ballast x="-3.198" y="+0.0" z="-0.782" mass="534.5"/>


  

<weight x="-1.196" y="-.33"  z="-0.275" mass-prop="/sim/weight[0]/weight-lb"/>	<!-- pilot -->
<weight x="-1.196" y=".33" z="-0.275" mass-prop="/sim/weight[1]/weight-lb"/>	<!-- co-pilot -->
<weight x="-2.073" y="-.33"  z="-0.275" mass-prop="/sim/weight[2]/weight-lb"/>	<!-- right passenger -->
<weight x="-2.073" y="0"    z="-0.275" mass-prop="/sim/weight[3]/weight-lb"/>	<!-- middle passenger -->
<weight x="-2.073" y=".33" z="-0.275" mass-prop="/sim/weight[4]/weight-lb"/>	<!-- left passenger -->
<weight x="-3.5" y="0"    z="-0.275" mass-prop="/sim/weight[5]/weight-lb"/>	<!-- patient/load -->

<!--weight by the additional things like emergency floats, skibox, FLIR...To DO: add the missing things-->
<weight x="-3.198" y="0.0"   z="-0.078" size="0.0" mass-prop="/sim/model/ec135/external/HEMS/weight-lb"/>
<weight x="-3.198" y="0.0"   z="-0.078" size="0.0" mass-prop="/sim/model/ec135/external/VIP/weight-lb"/>
<weight x="-3.198" y="0.0"   z="-0.078" size="0.0" mass-prop="/sim/model/ec135/external/Utility/weight-lb"/>
<weight x="0.138" y="0.0"   z="-0.096" size="0.2" mass-prop="/sim/model/ec135/external/BigRadom/weight-lb"/>
<weight x="0.138" y="0.0"   z="-0.096" size="0.1" mass-prop="/sim/model/ec135/external/smallradom/weight-lb"/>
<weight x="0.249" y="0.0"   z="-0.337" size="0.2" mass-prop="/sim/model/ec135/external/searchlight_front/weight-lb"/>
<weight x="-0.538" y="0.924"   z="-0.837" size="0.2" mass-prop="/sim/model/ec135/external/searchlight_left/weight-lb"/>
<weight x="-0.571" y="-1.096"   z="-0.984" size="0.5" mass-prop="/sim/model/ec135/external/FLIR/weight-lb"/>
<weight x="0.031" y="-0.397"   z="-0.772" size="0.4" mass-prop="/sim/model/ec135/external/mirror/weight-lb"/>
<weight x="-1.244" y="0.0"   z="1.009" size="0.1" mass-prop="/sim/model/ec135/external/wirecutter_up/weight-lb"/>
<weight x="-0.212" y="0.0"   z="-0.518" size="0.1" mass-prop="/sim/model/ec135/external/wirecutter_down/weight-lb"/>
<weight x="-2.197" y="0.0"   z="1.052" size="0.2" mass-prop="/sim/model/ec135/external/sandfilter/weight-lb"/>
<weight x="-3.9367" y="0.0"   z="1.060" size="0.0" mass-prop="/sim/model/ec135/external/IBF/weight-lb"/>
<weight x="-2.180" y="0.6"   z="0.625" size="0.2" mass-prop="/sim/model/ec135/external/winch/weight-lb"/>
<weight x="-0.755" y="0.316"   z="-0.694" size="0.0" mass-prop="/sim/model/ec135/external/SLLightL/weight-lb"/>
<weight x="-0.755" y="-0.316"   z="-0.694" size="0.0" mass-prop="/sim/model/ec135/external/SLLightR/weight-lb"/>
<weight x="-1.368" y="-0.311"   z="-0.956" size="0.1" mass-prop="/sim/model/ec135/external/loudspeaker/weight-lb"/>
<weight x="-1.368" y="0.357"   z="-1.034" size="0.1" mass-prop="/sim/model/ec135/external/hellas/weight-lb"/>
<weight x="-2.5218" y="0.0"   z="-1.123" size="0.1" mass-prop="/sim/model/ec135/external/snowboard_lowskid/weight-lb"/>
<weight x="-0.801" y="0.0"   z="-1.161" size="0.1" mass-prop="/sim/model/ec135/external/wirecutter_skid/weight-lb"/>
<weight x="-3.004" y="0.0"   z="-1.055" size="0.1" mass-prop="/sim/model/ec135/external/longskid_floats/weight-lb"/>
<weight x="-2.339" y="0.0"   z="-1.114" size="0.1" mass-prop="/sim/model/ec135/external/midskid/weight-lb"/>
<weight x="-2.5218" y="0.0"   z="-1.123" size="0.1" mass-prop="/sim/model/ec135/external/snowboard_midskid/weight-lb"/>
<weight x="-0.801" y="0.0"   z="-1.161" size="0.1" mass-prop="/sim/model/ec135/external/wirecutter_midskid/weight-lb"/>
<weight x="-2.339" y="0.0"   z="-1.223" size="0.1" mass-prop="/sim/model/ec135/external/highskid/weight-lb"/>
<weight x="-2.521" y="0.0"   z="-1.309" size="0.1" mass-prop="/sim/model/ec135/external/snowboard_highskid/weight-lb"/>
<weight x="-0.801" y="0.0"   z="-1.413" size="0.1" mass-prop="/sim/model/ec135/external/wirecutter_highskid/weight-lb"/>
<weight x="-2.481" y="0.0"   z="-0.852" size="0.0" mass-prop="/sim/model/ec135/external/multifunctioncarrier/weight-lb"/>
<weight x="-2.418" y="0.0"   z="-0.901" size="0.0" mass-prop="/sim/model/ec135/external/DoubleCargoHook/weight-lb"/>
<weight x="-4.767" y="-0.052"   z="-0.164" size="0.0" mass-prop="/sim/model/ec135/external/buckle/weight-lb"/>

These are the defined weight points in the .set file that I automatically read in the addon...

		<weight n="0">
			<name>Pilot</name>
			<weight-lb>180</weight-lb>
			<max-lb>300</max-lb>
		</weight>

		<weight n="1">
			<name>Co-Pilot</name>
			<weight-lb>180</weight-lb>
			<max-lb>300</max-lb>
		</weight>

		<weight n="2">
			<name>Right Passenger</name>
			<weight-lb>0</weight-lb>
			<max-lb>300</max-lb>
		</weight>

		<weight n="3">
			<name>Middle Passenger</name>
			<weight-lb>0</weight-lb>
			<max-lb>300</max-lb>
		</weight>

		<weight n="4">
			<name>Left Passenger</name>
			<weight-lb>0</weight-lb>
			<max-lb>300</max-lb>
		</weight>

		<weight n="5">
			<name>Load</name>
			<weight-lb>0</weight-lb>
			<max-lb>800</max-lb>
		</weight>

You can choose from any of these. The addon does pick on for you as default in the aircraft.xml file and configure the hitch and rope to match. But I think the aerotow point might also need to be included. It depends on what it is there for though.

I'll let you know when I push some changes I'm working on.

@wlbragg
Copy link
Owner

wlbragg commented Apr 27, 2020

@HHS81
OK, I think I got it fixed. There were a few different issues that had crept into the code. I still have some testing to do to verify several changes and bug fixes are good.
Please clear your aircraft data cache and pull the addon changes.

@HHS81
Copy link
Author

HHS81 commented Apr 27, 2020

@wlbragg No, now none of the helicopters is working....
Nasal runtime error: props.setValue() with non-number at C:/Users/Heiko/FlightGear/fgdata/Nasal/props.nas, line 33 called from: C:/Users/Heiko/FlightGear/Addons/Cargo-Towing-Addon/cargooperations.nas, line 328

@wlbragg
Copy link
Owner

wlbragg commented Apr 27, 2020

@HHS81
OK, missed a code block that needed some changes. Should be good now, need to pull and clear the aircraft cache.

@HHS81
Copy link
Author

HHS81 commented Apr 27, 2020

@wlbragg

@HHS81
OK, missed a code block that needed some changes. Should be good now, need to pull and clear the aircraft cache.

Success2

Now it works great! 👍

@HHS81
Copy link
Author

HHS81 commented Apr 27, 2020 •
edited
Loading

@wlbragg Some minor issues:
1.) the EC135/ H135 needs a different point for the longline. Winch and Longline has each different position. I can give the point for the longline

2.) some weird angle of the Cargo - without wind, without any movement of the helicopter hovering

Cargo_Angle

Otherwise I like it!

@wlbragg
Copy link
Owner

wlbragg commented Apr 27, 2020

I can give the point for the longline

Sure.

some weird angle of the Cargo - without wind, without any movement of the helicopter hovering

Yeah, there are quit a few minor glitches that need attention. Once I get things stable that is the next step, try to clean up animations and other stuff. If you look closely you'll see a few glitches.
A major one is the rope once connected to cargo, it needs to be mostly rewritten. It's far from natural and the physics are off. It acts more like a poll and less like a rope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wlbragg @HHS81