Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong starting directory when noxfile.py is a symlink #828

Open
rsyring opened this issue May 16, 2024 · 3 comments · May be fixed by #829
Open

Wrong starting directory when noxfile.py is a symlink #828

rsyring opened this issue May 16, 2024 · 3 comments · May be fixed by #829

Comments

@rsyring
Copy link

rsyring commented May 16, 2024

I have a project where I want the noxfille to be a symlink to a different shared file. When I do this, it throws off the paths b/c nox follows the symlink and starts in that directory instead of starting in the directory where the symlink is.

 ❯ ls -l noxfile.py 
lrwxrwxrwx 1 rsyring rsyring 21 May 15 23:09 noxfile.py -> ./template/noxfile.py

 ❯ nox -s cwd
nox > Running session cwd
nox > Creating virtual environment (uv) using python3 in .nox/cwd
cwd is: /home/rsyring/projects/copier-py-package/template

Was this an intentional design decision? If not, how about starting where the symlink is instead (i.e. don't follow it)?

Thanks for your work on this project and consideration.
@cjolowicz
Copy link
Collaborator

Thanks, PR welcome. Take a look in load_nox_module in tasks.py.

@henryiii
Copy link
Collaborator

That happens here:

nox/nox/tasks.py

Line 86 in a6e1a4e

global_config.noxfile = os.path.realpath(

The one below is fine (takes the global path of the dir), maybe it should just use that and reassemble the name.

@henryiii henryiii linked a pull request May 19, 2024 that will close this issue
Draft
@jamesharris-garmin
Copy link

I actually use this behavior with the repo tool to symlink a nox-file into the root of of my repo client clone directory and expect that the sessions I reference occur in a sub directory. It probably isn't a huge deal if you modify this behavior (I can also make it symlink the folders/change the paths.) but I thought I should note that there is someone out here who uses this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support noxfile being a symlink henryiii/nox
4 participants
@rsyring @cjolowicz @henryiii @jamesharris-garmin