fix: outer_env issues fixed #874
Open
+50
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/fix/envissues
branch
from
03e9762
to
827c8cf
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/fix/envissues
branch
from
87f0848
to
d52592c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #868. Two issues:
include_outer_env=Falsedoes nothing at all ifenv=is not passed. The outer env is still included.VIRTUAL_ENV(required foruv), andCONDA_PREFIX(required for conda-family) would not be included if you do set both.Fixing this was a bit intrusive: now
.envonly is the local environmentsettings, and removals are added to it using None. The type has changed to match
.command, with the None possibility. And then the final environment is built in the_run, where it can correctly process things like adding the bin dir and filtering the None's.