Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider providing a Cargo.lock #21

Open
vikanezrimaya opened this issue Feb 1, 2024 · 1 comment
Open

Please consider providing a Cargo.lock #21

vikanezrimaya opened this issue Feb 1, 2024 · 1 comment

Comments

@vikanezrimaya
Copy link

Current Rust best practices recommend committing Cargo.lock even for libraries: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

Additionally, this makes downstream packaging easier in some places, like nixpkgs, where a Cargo.lock is mandatory for Rust packages. I would love to package the xtr utility for nixpkgs, but the lack of Cargo.lock in your repository complicates things somewhat (while an out-of-tree Cargo.lock can be provided, it would be nice to have it provided in the repository).

Since this package provides an executable binary, it makes sense to provide a Cargo.lock in this repository even under the old guidelines.

@ogoffart
Copy link
Member

ogoffart commented Feb 3, 2024

I'm not a fan of putting the lock file in the repository. This is a tradeoff, and i think it just messes the git history.

Now, if this helps to get xtr packaged, I might reconsider this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants