Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_documentation.sh - Check for executables only when needed #7857

Closed
knight-of-ni opened this issue Aug 10, 2024 · 1 comment · Fixed by #7861 · May be fixed by #7858
Closed

generate_documentation.sh - Check for executables only when needed #7857

knight-of-ni opened this issue Aug 10, 2024 · 1 comment · Fixed by #7861 · May be fixed by #7858
Assignees

Comments

@knight-of-ni
Copy link

knight-of-ni commented Aug 10, 2024

Version

5.7.2

Description

generate_documentation.sh checks for exectuables such as git, cmake, g++, etc in all cases, whether they are needed or not.

This is problematic in a package building environment (rpm in my case) as that requires one to pull in additional packages that aren't used.

A PR to resolve this is incoming...

Background:
I have a fedora package review request for wolfssl here:
https://bugzilla.redhat.com/show_bug.cgi?id=2302646

I expect it to be approved shortly.

Currently, I am patching out all the "command -v" statements so the script succeeds when make dox-html is called during the build process. It would be nice if I didn't have to do this.

@embhorn
Copy link
Member

embhorn commented Aug 12, 2024

Hi @knight-of-ni

Thanks for recommending this improvement. I have requested a review by one of our engineers.

bandi13 pushed a commit to bandi13/wolfssl that referenced this issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants