Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid store does not support unique actions #1023

Closed
rrennick opened this issue Jan 9, 2024 · 2 comments
Closed

Hybrid store does not support unique actions #1023

rrennick opened this issue Jan 9, 2024 · 2 comments
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.

Comments

@rrennick
Copy link
Contributor

rrennick commented Jan 9, 2024

The action scheduler migration gets re-enabled every time a plugin is deactivated. In turn this switches AS to the hybrid data store which does not support unique actions.

I have a dev install that only runs AS actions through CLI that added ~1K copies of a unique action in a couple hours.

1- It should be safe to remove the code that re-enables the hybrid store as the DBStore has been default for almost 4 years.
2- The Hybrid store should support unique actions primarily for development/staging installs

@barryhughes barryhughes added type: bug The issue is a confirmed bug. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels Jan 11, 2024
@barryhughes
Copy link
Member

It should be safe to remove the code that re-enables the hybrid store as the DBStore has been default for almost 4 years.

For whenever we take this up: let's be careful on this point. Though it was a couple of years back, we did see a relatively popular third party plugin still shipping 2.x (and there could definitely be unmaintained custom plugins in the same boat).

Definitely great if we can do it safely.

@barryhughes
Copy link
Member

I think #1039 is a satisfactory solution for this problem. The post store is generally not used, and unless we decide to retain it as a backup for other problems (like missing tables [1] [2] [3]) then I don't think it's worth investing too much more time into the provision of full-fledged unique actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants