Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate usage of CronExpression #1221

Open
coreymckrill opened this issue Dec 6, 2024 · 1 comment
Open

Evaluate usage of CronExpression #1221

coreymckrill opened this issue Dec 6, 2024 · 1 comment
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@coreymckrill
Copy link
Contributor

coreymckrill commented Dec 6, 2024

As noted here, we are shipping an old, abandoned version of CronExpression in the lib folder. The library has since been forked by a new maintainer, and continues to be maintained to this day. Keeping around the old version is risky for PHP compatibility and security reasons, so I think we should:

  • Evaluate whether or not we still need to use this library
  • If so, consider removing it from version control and instead adding it as a composer dependency. This would also require auditing our usage of it, as the latest version has some breaking changes from the version we're currently using.
@Konamiman Konamiman added the type: task The issue is an internally driven task (e.g. from another A8c team). label Dec 11, 2024
@barryhughes
Copy link
Member

Updating it or replacing it may be safest from a back-compat standpoint, so long as we can maintain the same interface for our users. Support for cron expressions does feel like a situation where we're offering more than we perhaps should, but, it would also be hard to assess the impact of dropping support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

No branches or pull requests

3 participants