Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise test setup #1225

Open
barryhughes opened this issue Dec 13, 2024 · 0 comments
Open

Revise test setup #1225

barryhughes opened this issue Dec 13, 2024 · 0 comments

Comments

@barryhughes
Copy link
Member

barryhughes commented Dec 13, 2024

  • Review and revise our test suite as needed.
  • Make it more reliable in CI.
  • Make it easier to run locally.

Sometimes, our unit tests fail to run in CI. For whatever reason, this seems to surface in relation to community PRs in particular (example).

Frustratingly, based on my own recent experience, it is also challenging to run locally without jumping through various hoops (refer to the pr-unit-tests.yml workflow to see what I mean: if you are using a modern PHP, extra work is needed) and I would assume that means it is also difficult for community contributors (doubly so since, as already noted, there is a greater chance of CI not working in their case in addition to the challenge of making it run locally).

See also #1213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant