-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Campaign Creation: Add confirmation modal when user skips without creating a campaign #2504
Comments
@fblascogarma, @MatthiasReinholz, and @michaeleleder for this issue, I think we can use the We'll just need to confirm the title, content and button text we want to use. Here's an initial proposal for consideration: === Skip setting up ads? Enabling Performance Max is highly recommended to drive more sales and reach new audiences across Google Ads channels like Search, YouTube and Discover. Performance Max uses the best of Google’s AI to show the most impactful ads for your products at the right time and place. Google will use your product data to create ads for this campaign. Learn more about Performance Max. [Cancel] [Complete setup] |
I like it @joemcgill ! I would take out the "Ads" part. So instead of "across Google Ads channels like Search, YouTube and Discover", it would be: "across all Google channels like Search, YouTube and Discover." What do you think @MatthiasReinholz and @michaeleleder ? |
We reviewed with @MatthiasReinholz and @michaeleleder and looks good to us with that "Ads" removal change. Thanks! |
Perfect. Thanks for confirming! |
@ankitguptaindia this is ready for QA. |
Hello @joemcgill I have tested the PR, and it is functioning as described in the task details. However, I would like to propose a couple of enhancements to improve the user experience, when the merchant completes the onboarding without setting up a campaign. cc: @asvinb Current Behavior:
Suggestion 1: Improve Button TextCurrent Button Text: Complete setup Proposed Button Text: Complete setup without setting up ads In its current state, the button label Complete setup might not convey the full implications of the action. If a merchant is skimming through the process or accidentally clicks the button, they might complete the onboarding without realizing they haven’t set up any ads. Updating the button text to Complete setup without setting up ads provides a clearer indication of what will happen, reducing the risk of accidental completion. Suggestion 2: Add a Confirmation CheckboxProposal: Introduce a checkbox with a confirmation message, such as “I understand that I am completing the setup without setting up ads.” The Complete setup button would only become active once the checkbox is checked.
Adding a confirmation checkbox will require the merchant to actively acknowledge that they are completing the setup without setting up ads. This approach is similar to the "Disconnect all accounts" screen and can help ensure that merchants are fully aware of their actions before proceeding. It also reduces the likelihood of accidental onboarding completion. Benefits of This Approach:
|
Thanks for these suggestions, @ankitguptaindia! I agree that the button text could be more clear. Let's update it per your suggestion. Personally, I think the additional check-box is probably unnecessary. The whole AYS modal acts as a confirmation that someone wants to complete the setup without setting up Ads. By the time they see this modal they have already clicked a "Skip Ads" button and are given the choice to either "Cancel" (go back to set up Ads) or "Complete setup without setting up ads". A third confirmation seems pretty heavy handed. |
@eason9487 this one is ready for your review. |
Engineering complete and approved, moving to UAT for @fblascogarma final approval |
Just tagging @joemcgill and @kt-12 to advise this needs to be merged please |
Part of #2459
Today when merchants decide to skip campaign creation, they finish onboarding and get the following success modal.
And if they click Next, they see the following modal.
We propose that users that click on skip campaign creation get shown an "Are you sure" (AYS) modal with a message saying that campaigns is highly recommended to drive sales and asking "are you sure you want to skip this?" If they click yes, we finish onboarding and we show the same modals as we do today. If they click no, they should stay in campaign creation to finish the task.
Example Modal:
Modal content:
Skip setting up ads?
Enabling Performance Max is highly recommended to drive more sales and reach new audiences across Google channels like Search, YouTube and Discover.
Performance Max uses the best of Google’s AI to show the most impactful ads for your products at the right time and place. Google will use your product data to create ads for this campaign.
Learn more about Performance Max.
[Cancel] [Complete setup without setting up ads]
Acceptance Criteria
Implementation Brief
A new AppModal component will need to be added to the
js/src/setup-mc/setup-stepper/setup-paid-ads/setup-paid-ads.js
step. ThecreateSkipButton()
function will need to be updated so that the onClick callback triggers opening the modal rather than finishing the onboarding step.The new modal will need to have two action buttons, the "No" button that closes the modal and the "Yes" button that closes the modal and calls the
finishOnboardingSetup()
function. This button will also need to includedata-action={ ACTION_SKIP }
so the correct event is recorded when the onboarding is completed.Test Coverage
tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js
theComplete onboarding by "Skip this step for now"
will need to be updated to account for the AYS modal instead of completing the onboarding. There should be new tests that account for the behavior of both modal buttons.The text was updated successfully, but these errors were encountered: