Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap and rename dashboard performance cards #2537

Open
2 tasks
Tracked by #2460
joemcgill opened this issue Aug 16, 2024 · 1 comment · Fixed by #2564
Open
2 tasks
Tracked by #2460

Swap and rename dashboard performance cards #2537

joemcgill opened this issue Aug 16, 2024 · 1 comment · Fixed by #2564
Assignees

Comments

@joemcgill
Copy link
Collaborator

joemcgill commented Aug 16, 2024

Part of #2460

The current dashboard includes two SummaryCard components for "Performance (Free Listing)" (free listings) and "Performance (Paid Campaigns)" (paid campaigns). See current screenshot:

Image

In order to better highlight the value of setting up paid ads, we'll swap these two cards and rename them to “Google Ads” (paid campaigns) and “Free Listings (Limited Visibility)” (free-listings)

Acceptance Criteria

On the dashboard:

  • The first SummaryCard should be titled "Google Ads" and show the PaidPerformanceCard when the ads setup is complete, or PaidCampaignPromotionCard when not.
  • The second SummaryCard should be titled "Free Listings (Limited Visibility)" and show the FreePerformanceCard component.

Implementation Brief

This PR should be merged into the feature/2460-google-ads-value-prop branch.

The file where these can be swapped and renamed is found here.

Test Coverage

  • Jest tests in js/src/dashboard/summary-section/summary-section.test.js should still pass.
  • E2E tests that rely on the "Add paid campaign" button in the PaidCampaignPromotionCard component should still pass after swapping positions. If not, update the tests so they aren't dependent on the position of the SummaryCard.

Definition Questions

@eason9487
Copy link
Member

This looks good for the Definition phase.

@asvinb asvinb self-assigned this Aug 23, 2024
@asvinb asvinb assigned joemcgill and unassigned asvinb Aug 23, 2024
@joemcgill joemcgill linked a pull request Aug 26, 2024 that will close this issue
@ankitguptaindia ankitguptaindia removed their assignment Aug 28, 2024
@joemcgill joemcgill assigned eason9487 and fblascogarma and unassigned eason9487 Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants