From b431de30c606718d8ff4933da59127dd2d7cec2d Mon Sep 17 00:00:00 2001 From: Eason Su Date: Wed, 4 Sep 2024 18:45:46 +0800 Subject: [PATCH] Allow npm `^9` because dependabot is using an npm version that doesn't pair with Node.js 20. --- README.md | 3 +++ package-lock.json | 2 +- package.json | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 53790f6a..e2bb4ab9 100644 --- a/README.md +++ b/README.md @@ -19,6 +19,9 @@ Google Analytics for WooCommerce utilizes npm scripts for task management utilit `npm run build` - Runs the tasks necessary for a release. These may include building JavaScript, SASS, CSS minification, and language files. +The `engines` in package.json includes npm `^9` to allow dependabot to update our dependencies. However, it's not the version intended to be used in development. + +- See https://github.com/dependabot/dependabot-core/issues/9277 ## Unit tests ### Running PHP unit tests in your local dev environment diff --git a/package-lock.json b/package-lock.json index cd18de32..d1066c43 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25,7 +25,7 @@ }, "engines": { "node": ">=20", - "npm": ">=10" + "npm": ">=10 || ^9" } }, "node_modules/@aashutoshrathi/word-wrap": { diff --git a/package.json b/package.json index 8de71fe7..134973df 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ }, "engines": { "node": ">=20", - "npm": ">=10" + "npm": ">=10 || ^9" }, "config": { "wp_org_slug": "woocommerce-google-analytics-integration",