You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a conflict with International Phone Number Format plugin on international phone number validation and your extension.
You should adapt your validation code in order to support E.164 international phone number format.
Go at the PayPal plugin in modules/ppcp-api-client/src/Factory/PayerFactory.php
You should adapt the code to support international numbers that contain the "+" sign.
public function from_wc_order( \WC_Order $wc_order ): Payer {
$payer_id = '';
$birthdate = null;
$phone = null;
if ( $wc_order->get_billing_phone() ) {
// make sure the phone number contains only numbers and is max 14. chars long.
$national_number = $wc_order->get_billing_phone();
$national_number = preg_replace( '/[^0-9]/', '', $national_number );
$national_number = substr( $national_number, 0, 14 );
if ( $national_number ) {
$phone = new PhoneWithType(
'HOME',
new Phone( $national_number )
);
}
}
PayPal orders may not go through because of this conflict.
It is better to have support for E.164 standard to have reliable SMS notifications for shipping.
Expected Behavior
Support E.164 and PayPal orders would go through.
Actual Behavior
PayPal orders are not going through because of incomplete billing phone validation.
Environment
WordPress Version: latest
WooCommerce Version: latest
Plugin Version: latest
Browser [e.g. Chrome, Safari] and Version: Chrome, Safari, all latest
Any other plugins installed: many including International Phone Number Format plugin
The text was updated successfully, but these errors were encountered:
Describe the Bug
There is a conflict with International Phone Number Format plugin on international phone number validation and your extension.
You should adapt your validation code in order to support E.164 international phone number format.
To Reproduce
modules/ppcp-api-client/src/Factory/PayerFactory.php
PayPal orders may not go through because of this conflict.
It is better to have support for E.164 standard to have reliable SMS notifications for shipping.
Expected Behavior
Support E.164 and PayPal orders would go through.
Actual Behavior
PayPal orders are not going through because of incomplete billing phone validation.
Environment
The text was updated successfully, but these errors were encountered: