Terminate reconnect_loop process when client terminates #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
approved these changes
Sep 22, 2020
src/eredis_client.erl
Outdated
| _ -> | ||
| reconnect_loop(Client, State) | ||
| receive | ||
| {'EXIT', _, Reason} -> exit(Reason) |
There was a problem hiding this comment.
Here _ is Client, right? We could be explicit here to make it easier to understand the code. Or at least a comment about when/why this can happen.
bjosv
force-pushed
the
reconnect_loop_correction
branch
from
e66c776 to
d0ee41c
Compare
zuiderkwast
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves wooga#124