Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Support: Investigate Reachability issues. #11840

Closed
diegoreymendez opened this issue Jun 1, 2019 · 3 comments
Closed

Offline Support: Investigate Reachability issues. #11840

diegoreymendez opened this issue Jun 1, 2019 · 3 comments

Comments

@diegoreymendez
Copy link
Contributor

diegoreymendez commented Jun 1, 2019

This issue was spawned off this PR.

In that PR I noticed Reachability isn't calling the network availability closures reliably. In fact they're only called once apparently.

Investigate how this can be resolved.

Options to Consider:

  1. Investigate the different mechanisms we use in the App for reachability.
  2. Consider using this library, or another similar library.

On NWPathMonitor:

We can't exclusively use NWPathMonitor because it's only supported in iOS 12+, but we could consider using it conditionally for now so that when we drop support for earlier iOS versions, we can fully switch to it.

@yaelirub
Copy link
Contributor

yaelirub commented Jun 3, 2019

might be helpful: WWDC 2012 session 706 networking best practices

@diegoreymendez
Copy link
Contributor Author

This issue seems to be known: tonymillion/Reachability#171

@diegoreymendez
Copy link
Contributor Author

I've tested this using a device instead of the simulator, and it's working fine.

Closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants