Plugin update false positive on WP Core dependency.

[eckelarsson]

Issue with command: wp plugin update --all --patch|minor

WP CLI Version: 2.1.0
WP Core Version: 5.0.4

The plugin sassy-social-share current version is 3.2.16 and update version is 3.2.17 and wp cli treat that as an major update, it will not update that plugin if you add --patch or --minor.

Then I saw in the changelog for the plugin, that it was a patch for Wordpress version 5.1.
I guess that the update depends on WP Core 5.1 before it should/can update. (You can force an update via WP CLI)

Because in the interface version, when logged in and check if an update exists for the plugin, it don't.

The behavior should be that the plugin should not be listed as having an update available.
This includes in all commands I guess, wp plugin list, wp plugin status etc etc.

[schlessera]

WordPress has been adding more checks before doing updates, and we'll need to go through WP-CLI logic and make sure it is adapted to this new behavior.

There is work on making these checks more easily available, but we might need to provide fallback as well. See https://core.trac.wordpress.org/ticket/46599