context=admin executes admin_init before anything on init is executed potentially causing fatal errors #6010
Comments
That's not normal. It's supposed to happen right before |
|
|
|
Also there's a bug here https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Context/Admin.php#L63 - when a --user is provided, it should use that user and not arbitrarily fall back to ID 1 since this will make EDIT: looks like the correct code is there https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Runner.php#L1655 but the user then gets overwritten by the wrong user in https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Context/Admin.php#L63 (since that init hook was added later it runs after) - I guess a simple check whether the user is set already in https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Context/Admin.php#L63 would be sufficient before overwriting it with id 1 |
|
This seems to be completely broken at the moment. Here is a working reproduction script. # Create docker compose file
cat <<EOT > docker-compose.yml
services:
wordpress:
image: wordpress:latest
container_name: wordpress
environment:
WORDPRESS_DB_NAME: example_db
WORDPRESS_DB_USER: example_user
WORDPRESS_DB_PASSWORD: example_pass
WORDPRESS_DB_HOST: db:3306
ports:
- "8000:80"
volumes:
- wordpress_data:/var/www/html
depends_on:
- db
db:
image: mysql:latest
container_name: wordpress_db
environment:
MYSQL_DATABASE: example_db
MYSQL_USER: example_user
MYSQL_PASSWORD: example_pass
MYSQL_ROOT_PASSWORD: example_root_pass
volumes:
- db_data:/var/lib/mysql
volumes:
wordpress_data:
db_data:
EOT
# Initialize containers
docker compose up -d
# Install dependencies and WP CLI
docker compose exec -T wordpress bash <<EOF
apt-get update
apt-get install -y less mariadb-client
curl -O https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar
php wp-cli.phar --info # This will verify WP-CLI is installed correctly
chmod +x wp-cli.phar
mv wp-cli.phar /usr/local/bin/wp
EOF
# Install wordpress
docker compose exec -T -u www-data wordpress bash <<EOT
until wp db check; do
sleep 1
done
wp core install --url=http://localhost:8000 --title="Test" --admin_user=admin --admin_password=password [email protected]
EOT
# Testing that eval works (outputs 50 like expected)
docker compose exec -T -u www-data wordpress wp eval "$(cat <<'EOT'
$value = 13;
echo ($value+37) . "\n";
EOT
)"
# Testing eval with context (nothing happens)
docker compose exec -T -u www-data wordpress wp --user=1 --context=admin eval "$(cat <<'EOT'
echo 'Test with: --user=1 --context=admin';
function init_cb() {
var_dump( 'this is init' );
}
add_action( 'init', 'init_cb' );
function admin_init_cb() {
var_dump( 'this is admin init' );
}
add_action( 'admin_init', 'admin_init_cb' );
var_dump(function_exists('add_action'));
EOT
)"
docker compose exec -T -u www-data wordpress wp --context=admin eval "$(cat <<'EOT'
echo 'Test with: --context=admin';
function init_cb() {
var_dump( 'this is init' );
}
add_action( 'init', 'init_cb' );
function admin_init_cb() {
var_dump( 'this is admin init' );
}
add_action( 'admin_init', 'admin_init_cb' );
var_dump(function_exists('add_action'));
EOT
)"
docker compose exec -T -u www-data wordpress wp eval "$(cat <<'EOT'
echo 'Test with nothing';
function init_cb() {
var_dump( 'this is init' );
}
add_action( 'init', 'init_cb' );
function admin_init_cb() {
var_dump( 'this is admin init' );
}
add_action( 'admin_init', 'admin_init_cb' );
var_dump(function_exists('add_action'));
EOT
)" |
|
Looking at the test again I see that admin_init shouldn't run... So maybe it works as intended. |
Bug Report
Describe the current, buggy behavior
Describe how other contributors can replicate this bug
Describe what you expect as the correct outcome
in theme functions.php add:
Then run:
You will get:
However, this is the opposite order of what it would normally be in an wp-admin request.
Let us know what environment you are running this on
Provide a possible solution
The issue is https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Context/Admin.php#L45 is run on init hook with earliest priority (PHP_INT_MIN)
To keep it consistent with WP core, it needs to be loaded on
wp_loadedwithPHP_INT_MAX(last hook in settings.php)And the user auth https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Context/Admin.php#L44 is wrong too. Normally the user is set up already on
plugins_loaded- therefore that needs to be called onplugins_loadedwithPHP_INT_MINAlso there's a bug here https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Context/Admin.php#L63 - when a --user is provided, it should use that user and not arbitrarily fall back to ID 1 since this will make
current_user_canchecks fail and therefore the context=admin is pointless, since it's an unauthenticated request anywayEDIT: looks like the correct code is there https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Runner.php#L1655 but the user then gets overwritten by the wrong user in https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Context/Admin.php#L63 (since that init hook was added later it runs after) - I guess a simple check whether the user is set already in https://github.com/wp-cli/wp-cli/blob/main/php/WP_CLI/Context/Admin.php#L63 would be sufficient before overwriting it with id 1
The text was updated successfully, but these errors were encountered: