Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk optimization - percentage optimization indicator jumps inconsistently during the process #840

Closed
markonikolic985 opened this issue Mar 6, 2024 · 2 comments
Labels
priority: medium Issues which are important, but no one will go out of business. type: enhancement UI

Comments

@markonikolic985
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
Testing v2.2 alpha, we noticed some inconsistencies during the bulk optimization process.

In the v2.1 the Bulk optimization works the way data is updated when image is optimized (% and number of optimized images) one by one (image and %), like this - https://capture.dropbox.com/726omrg388oYIvbf

However, in the v2.2 it does not update, but jumps from 0% to 50% or so, as well as the number of original images optimized by Imagify.

Also, in another test, the number of optimized images went down and the percentage indicator was gone (when checked in the Media Library, optimzation was still running). Check this screenrecoed - https://capture.dropbox.com/W7I1XZogDscBUXw2

Note: At some moment, Imagif'em all button will stop spinning, but when you go to the Media Library, optimization is still running for many images. This particular problem already has its' own issue in #756 .

To Reproduce
Steps to reproduce the behavior:

  1. Make sure you use v2.2
  2. Go to the Bulk optimization page
  3. Click on "Imagif'em All" button
  4. Wait for optimization to start.
  5. Check the number of optimized images and percentage indicator
  6. Percentage will jump from 0-x% instead going one by one. The number of original optimized images will change accordingly

Expected behavior
Percentage indicator should show the progress one % by one, as it's the case in versions prior to v2.2, as well as the number of original images optimized by Imagify.

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@piotrbak piotrbak added type: enhancement needs: grooming UI priority: medium Issues which are important, but no one will go out of business. labels Mar 7, 2024
@piotrbak piotrbak added this to the 2.2.1 milestone Mar 7, 2024
@Mai-Saad
Copy link

fixed on #842

@piotrbak piotrbak removed this from the 2.2.1 milestone Mar 12, 2024
@Tabrisrp
Copy link
Contributor

We can close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Issues which are important, but no one will go out of business. type: enhancement UI
Projects
None yet
Development

No branches or pull requests

4 participants