Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMP iframe src attribute errors #58

Open
lkraav opened this issue Jun 25, 2018 · 3 comments
Open

AMP iframe src attribute errors #58

lkraav opened this issue Jun 25, 2018 · 3 comments
Assignees
@remyperona
Labels
waiting for feedback

Comments

@lkraav
Copy link

lkraav commented Jun 25, 2018

Hi. We probably need to avoid rendering our lazy load markup optimizations during AMP output and let AMP plugin take care of it instead.

https://github.com/Automattic/amp-wp/ for details.
@remyperona remyperona self-assigned this Jul 3, 2018
@remyperona
Copy link
Contributor

It should already be the case, we have a compatibility file specifically for that plugin. I'm doing a little update to it to improve in the next minor version, but this should already be working correctly.

@lkraav
Copy link
Author

lkraav commented Jul 5, 2018

I've deployed 1.4.8 and triggered re-validation in Google Search Console. I'll post an update here when robots have completed their work.

@remyperona
Copy link
Contributor

Did the issue persist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remyperona remyperona

Labels
waiting for feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkraav @remyperona