Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scenario urls for delayjs #149

Closed
jeawhanlee opened this issue Sep 19, 2024 · 0 comments · Fixed by #150
Closed

Update scenario urls for delayjs #149

jeawhanlee opened this issue Sep 19, 2024 · 0 comments · Fixed by #150
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@jeawhanlee
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
In this PR we forgot to add the urls for delayjs script and so when we run npm run test:delayjs:genesis or any delayjs related test, we will not get the scenario urls because it was removed.

To Reproduce
Steps to reproduce the behavior:

  1. Run any of the related delayjs tests:
    "test:delayjs:genesis": "THEME=genesis-sample-develop $npm_package_config_testCommand --tags @delayjs",
    "test:delayjs:flatsome": "THEME=flatsome $npm_package_config_testCommand --tags @delayjs",
    "test:delayjs:divi": "THEME=Divi $npm_package_config_testCommand --tags @delayjs",
    "test:delayjs:astra": "THEME=astra $npm_package_config_testCommand --tags @delayjs",
  2. See that backstop references are not created for it.

Expected behavior
We need to create backstop references when we run the following tests:

  • test:delayjs:genesis
  • test:delayjs:flatsome
  • test:delayjs:divi
  • test:delayjs:astra

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
We need to add scenario urls for delayjs here: https://github.com/wp-media/wp-rocket-e2e/blob/develop/config/scenarioUrls.json
We have it like so previously:

delayJs: {
    path: ''
},
delayJsMobile: {
    path: '',
    mobile: true,
},

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@jeawhanlee jeawhanlee added bug Something isn't working enhancement New feature or request labels Sep 19, 2024
@jeawhanlee jeawhanlee self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant