-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only rename debug.log with errors relating to WPR #67
Comments
Discussed as part of #54: Expected behavior
If the error log check discards a log file (meaning there are only errors not related to WP Rocket and errors discarded if the option is enabled), then the error log file must not be kept and this check must succeed (not make the test fail). |
AS per discussion with @jeawhanlee the part to ignore certain error will be handled at the helper plugin and it needs other GH |
Scope a solution ✅
In wp-rocket-e2e/src/support/hooks.ts Line 171 in 8b86f2b
Estimate the effort ✅[XS] |
LGTM |
Is your feature request related to a problem? Please describe.
Right now we rename debug.log for every scenario that creates it whether the errors in the log are WPR related or not.
Describe the solution you'd like
We should check for errors in the debug.log that relates to WPR and rename it if any is found.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: