-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Definition class to improve performance and reduce High CPU usage #6413
Comments
Pinging you here too @MathieuLamiot Do you think it's worth checking or doing R&D? |
Yes it is, however this is not something we should change in our plugin but in a dependency. We would need to share this report with PHP League container maintainers. |
@MathieuLamiot looking at it, it seems related to tags only on league container. We add tags into the plugin, but I don't recall we are actually using them. |
@CrochetFeve0251 You should directly discuss this topic with the plugin team and @Tabrisrp |
We can remove tags usage from the plugin, since it's not compatible with the way we use ServiceProviders, as I discuss a couple of years ago with the dev of the container |
We have received some suggestions about how the Definitions class can be altered to improve the plugin's performance and potentially decrease CPU usage. Specific details can be found here:
https://secure.helpscout.net/conversation/2490895571/471075/#thread-7472405567
Here is the full content of the suggested changes:
Additional context
https://secure.helpscout.net/conversation/2490895571/471075/ - Ticket
https://wp-media.slack.com/archives/C43T1AYMQ/p1706280695093479 - Slack Discussion
Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
The text was updated successfully, but these errors were encountered: