fix: Correctly parse nested attribute and tag sources. #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8531653 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justlevine
force-pushed
the
tests/core-table-backfill
branch
from
bf73892 to
0cf502b
Compare
justlevine
changed the title
justlevine
force-pushed
the
tests/core-table-backfill
branch
from
ef185f8 to
750fdbf
Compare
justlevine
force-pushed
the
tests/core-table-backfill
branch
from
750fdbf to
8531653
Compare
|
Ta! |
theodesp
approved these changes
Sep 26, 2024
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes an issue with nested attributes (such as those used by CoreTable) not being resolved correctly.
More specifically, it:
::parse_attribute()is called correctly regardless of if there is aselectorpresent.tagsourcesAdditionally, tests have been backfilled specific CoreTable attributes.
Why
Fixes #282
Test Coverage
Important
This PR is based on #284 which should be merged first.
Relevant diff 1192a61
Covered
CoreTableAttributesNot covered
CoreTableAttributes.metadataAdditional notes:
The new
DOMHelpers::get_first_node_tag_name()is marked as internal, because the entire class needs to be reworked (and ideally replaced with WordPress's HTML parsing api ).