Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency installation via Dashboard message needs status indicator #1

Open
jaswrks opened this issue May 28, 2016 · 2 comments
Open

Comments

@jaswrks
Copy link

jaswrks commented May 28, 2016

@raamdev writes...

When installing the s2Member X plugin on a site that does not have any of the dependencies installed, several Dashboard messages will appear in succession presenting you with a link to install WP Sharks Core and then WooCommerce.

2016-05-25_10-20-50

However, when you click the link to install, there is no indication that something is happening other than your browser appearing to be connecting to something (presumably loading another page).

If the process takes longer than what you're used to waiting when loading web pages, you start to think that something is wrong and the instinct is to refresh the page or try again (which in this case would be the wrong thing to do and would totally break the intended workflow).

What we need is a JS indicator that shows that something is happening, something that turns the "Click here to install '[software]'" link into "Installing..." with a little spinning indictor, just like on the WordPress plugins page when updating a plugin inline:

plugin-update-inline


@jaswsinc writes...

Ah.. Thanks! Yeah, I noticed this too whenever I was testing locally. I think it's a problem in WordPress core actually. The underlying problem is that whenever I was testing locally the PHP script did not flush enough output for the page to change and for WordPress to display the status of what was happening as would normally be expected. I'm not sure exactly what causes this locally yet though.

Let me know if this is a WP-PHP-RV issue; if so, I'll open a cross-issue over there.

I'd call this a WP Sharks Core issue, so if you'd like to move it there I think that would be better. When this is corrected, it will change in the WP Sharks Core repo, and in the WP Sharks Core RV repo.

@jaswrks jaswrks added the bug label May 28, 2016
@jaswrks
Copy link
Author

jaswrks commented May 28, 2016

Related core ticket: https://core.trac.wordpress.org/ticket/18525

@jaswrks
Copy link
Author

jaswrks commented May 28, 2016

Related core function that is supposed to prevent this from becoming an issue.
https://developer.wordpress.org/reference/functions/show_message/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant