-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure a Docker container to run wwwhisper #3
Comments
I hacked together a docker version @ https://github.com/xeor/dockerfiles/tree/master/wwwhisper |
This looks cool, I'll play with it. Thank you :) Do you have any suggestions what could be improved in wwwhisper to improve/clean the Docker setup? |
It really depends on how you want it used in docker. I made it very specific and locked down to use only linked containers that exposes port 80 (hardcoded port for now). I think the ultimate solution here would be to have it listen to the docker socket and generates the a dynamic nginx file that wwwhisper uses when a container is created with an evironmentvariable, example '-e WWWHISPER=gitlab' would creates a /gitlab directory protected by wwwhisper. See https://github.com/jwilder/nginx-proxy for something that does almost this.. The biggest annoyance getting this to work with docker was the virtualhost dependencies. Even tho virtualhost is supernice, its not something you need in docker. I tried to do it without virtualhost, but was digging myself longer and longer down into what could considered "more clean than just using virtualhost" :) |
Thanks, I'll experiment with different approaches and see if things can be simplified. I was also thinking about running wwwhisper in a container that is separate from nginx container. There are middlewares that allow to use wwwhisper without nginx from Ruby Rack and nodejs. Running wwwhisper in its own Docker container could potentially allow to easily setup these middlewares (but this also will require some changes in wwwhisper). |
Using Docker can simplify setup of a standalone wwwhisper instance.
The text was updated successfully, but these errors were encountered: