Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to AssertWslSupported? #1

Open
chadjefferies opened this issue Sep 14, 2022 · 0 comments
Open

Changes to AssertWslSupported? #1

chadjefferies opened this issue Sep 14, 2022 · 0 comments

Comments

@chadjefferies
Copy link

chadjefferies commented Sep 14, 2022

Hello and thank you for this library!

Question on if you'd be open to changes to AssertWslSupported or more likely an entirely new method(s)? I feel it could be useful to know why WSL is not supported on a system, e.g. supported but not installed versus not supported at all?

Right now, I have to catch PlatformNotSupportedException to know if the system does not support WSL at all and a NotSupportedException to know if the system supports it but it is just not installed. It feels a little hacky to depend on internal implementation details like that (though if this was a design choice, that is good to know also and maybe catching those exceptions is an OK approach).

I'd be willing to create a PR to add a new method that returns some kind of status enum or possibly a set of new methods, one to detect if WSL is supported and one to check if WSL is installed.

Let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant