Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AnalyticsDataPublisher to Handle Multiple Reporter Types #12580

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Piumal1999
Copy link

@Piumal1999 Piumal1999 commented Sep 22, 2024

Purpose

To improve the flexibility of APIM analytics by allowing users to configure multiple reporter types. Previously, it was limited to a single reporter type specified in the configuration, defaulting to Choreo analytics if not explicitly set. This PR enables users to setup multiple analytics reporters simultaneously.

Issues

Fixes wso2/api-manager#3099

Approach

The new implementation allows for multiple loggers to be enabled through configuration in the deployment.toml file. Users can now specify an array of reporter types, which the system will process and initialize accordingly.

Configuration Examples

Enable both Choreo and ELK analytics:

[apim.analytics]
enable = true
type = ["choreo", "elk"]

In this case, type = "choreo, elk" is also allowed.

Enable only ELK analytics:

[apim.analytics]
enable = true
type = ["elk"]

In this case, type = "elk" is also allowed.

Default behavior (Choreo analytics) when type is not defined:

[apim.analytics]
enable = true

Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2024

CLA assistant check
All committers have signed the CLA.

@Piumal1999 Piumal1999 force-pushed the APIM-3099 branch 2 times, most recently from 994bb31 to f77b855 Compare September 23, 2024 03:33
@chamilaadhi
Copy link
Contributor

adding @AnuGayan

@Piumal1999 Piumal1999 marked this pull request as ready for review September 25, 2024 05:38
@Piumal1999
Copy link
Author

Hi @AnuGayan ,
I updated the code allowing configuration in type = "a, b" format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APIM] Enable the apim-metrics.log without enabling the ELK analytics type
3 participants