Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for variable model types within the same Skeleton #50

Open
wtbarnes opened this issue Dec 7, 2020 · 3 comments
Open

Allow for variable model types within the same Skeleton #50

wtbarnes opened this issue Dec 7, 2020 · 3 comments

Comments

@wtbarnes
Copy link
Owner

wtbarnes commented Dec 7, 2020

Currently, it is assumed throughout the codebase that every loop is defined using the same model and model interface. This assumption should be relaxed such that a single Skeleton can have a mix of models in a single skeleton. This could be useful, say, in using a simple model to create a background and then modeling a selection of loops a more sophisticated model.

One option would be to just create two (or more) distinct Skeletons, load their loop simulations, and then add their loops together to create a new Skeleton. However, there are still places where it is assumed that all loops in the Skeleton have the same model. I need to go through and double check and make sure I understand where all of those places are.

@wtbarnes
Copy link
Owner Author

wtbarnes commented Dec 7, 2020

Actually, it seems the only place this occurs is load_ionization_fractions which assumes that all loops have the same model interface anyway. So maybe there just needs to be a check there to ensure that all the model types are in fact the same

@wtbarnes
Copy link
Owner Author

Another consideration and probably the most difficult one to resolve, is the differences in simulation times between different models. As long as they are over the same interval, this is fine as they'll just be interpolated to the instrument time. But in the case of something like a background model where some of the loops don't evolve with time, we'll need to come up with some other way to deal with this.

@wtbarnes
Copy link
Owner Author

wtbarnes commented May 3, 2022

Maybe the easiest way to do this is to just define a compound model interface who's load_loop_simulation method just hands off the loading to some other set of pre-defined interfaces based on some properties of the loop (e.g. length). This could be illustrated in the example gallery.

@wtbarnes wtbarnes mentioned this issue May 3, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant