Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeup loss #2

Open
SeeU1119 opened this issue Oct 18, 2019 · 7 comments
Open

makeup loss #2

SeeU1119 opened this issue Oct 18, 2019 · 7 comments

Comments

@SeeU1119
Copy link

SeeU1119 commented Oct 18, 2019

Hi, thanks for your implement work, but i doubt wheater the implement of makeup loss is correct, the paper says that we should calculate the histogram matching between src image and ref image firstly, then calculate the l2 norm between fake image which generated by generator and matched image, i
find that you just calculate makeuo loss between the generated image and reference image which dont normlization the value to [-1, 1], and use L1 norm, could you help me? thanks!

@wtjiang98
Copy link
Owner

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

@CodingMice
Copy link

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

@wtjiang98
Copy link
Owner

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

Yes, your observation is normal. Because HM is only a coarse gudiance, which need adv training to refine. If the results are perfect, there is no need to propose BeautyGAN.

@CodingMice
Copy link

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

Yes, your observation is normal. Because HM is only a coarse gudiance, which need adv training to refine. If the results are perfect, there is no need to propose BeautyGAN.

Okay. Could you please tell me how to balance the weights of all losses? I have tried many times before...

@wtjiang98
Copy link
Owner

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

Yes, your observation is normal. Because HM is only a coarse gudiance, which need adv training to refine. If the results are perfect, there is no need to propose BeautyGAN.

Okay. Could you please tell me how to balance the weights of all losses? I have tried many times before...

lambda_his = 1
lambda_his_lip = 1
lambda_skin = 0.1
lambda_eye = 1
The default settings at 'train.py'

@CodingMice
Copy link

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

Yes, your observation is normal. Because HM is only a coarse gudiance, which need adv training to refine. If the results are perfect, there is no need to propose BeautyGAN.

Okay. Could you please tell me how to balance the weights of all losses? I have tried many times before...

lambda_his = 1
lambda_his_lip = 1
lambda_skin = 0.1
lambda_eye = 1
The default settings at 'train.py'

Thank you. It is the same as the description in paper. And I wonder how you get that weights, and the weights of GANLoss.

@Hao-Ning
Copy link

Hao-Ning commented Jan 7, 2020

Does it work? How do I import the data set? I have a problem importing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants