Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question - is it possible to specify the secret name ? #6

Open
cameronbraid opened this issue Mar 5, 2020 · 2 comments
Open

question - is it possible to specify the secret name ? #6

cameronbraid opened this issue Mar 5, 2020 · 2 comments

Comments

@cameronbraid
Copy link
Contributor

Hi,

I am wanting to use this csi driver to access more than one rclone backend, so ideally I would create a secret for each remote and then the PV can specify a secret to use.

Currently it looks like only 1 secret named 'rclone-secret' will be used. Is this correct ?

Would it be a hard change to support an additional field in the PersistentVolume spec to provide the name of the secret to use ?

@cameronbraid
Copy link
Contributor Author

I think its fairly straightforward #7

Its not tested, but if you are interested in this PR I will do some testing

@Jancis
Copy link
Member

Jancis commented Mar 20, 2020

It does look good, i started to need the same and was toying with the idea of having multiple storageclasses where csi-rclone would deploy all related instances based on storageclass and read the related secret, but your solution seems even better since it's fairly simple, has less overhead and does basically the same.
Would be great if you can test it too, i see that it's falling back to original secret so there should be no migration path necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants