Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Https #69

Open
jonathanjfshaw opened this issue Nov 19, 2018 · 1 comment
Open

Https #69

jonathanjfshaw opened this issue Nov 19, 2018 · 1 comment

Comments

@jonathanjfshaw
Copy link
Contributor

In #55 you added a readiness check to nginx.

It uses httpGet on port 80; it needs to be configurable to use port 443 and specify https as the 'scheme' or it fails nastily with intermittent 503 errors if an ingress is used that forces https.

See https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes for docs

I would make a PR but I'm not sure how you're planning to setup https, how you want to arrange the values.yaml for that.

@Jancis
Copy link
Member

Jancis commented Nov 22, 2018

TLS is going to be terminated in ambassador, internal comm will be 80 (at least for now). I believe we can add expose probe scheme and port as variables.

The TLS is one of the next tasks in queue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants