New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation error in CsvReader for header parameter #67

Open

rjsbhatia opened this issue Feb 27, 2020 · 0 comments

Collaborator

rjsbhatia commented Feb 27, 2020

In the documentation for CsvReader it says we can pass the header parameter. The example shows a possible value of None.

Example:
"csv_reader": {
"class": "CsvReader",
"filename": "data/mydata.csv",
"kwargs": {
"header": None,
"sep": ":"
}
} \

Json(and yaml) have issues with None.
If you pass Null instead of None the reader works.

https://github.com/WW-Digital/ww-primrose/blob/b8b0eb9befc78d42c48cd0573a1dc6d1dfaef71d/primrose/readers/csv_reader.py#L42

As an aside, I was trying to write this data to BigQuery and if there is no header the Bqwriter fails.

briangrahamww closed this as completed

briangrahamww reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment