Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional_config method and DAG config param check #75

Open
briangrahamww opened this issue Apr 8, 2020 · 0 comments
Open

optional_config method and DAG config param check #75

briangrahamww opened this issue Apr 8, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@briangrahamww
Copy link
Collaborator

We should add the ability to specify an optional method for optional_config, which returns a set of config params similar to the necessary_config. Then we could have the sphinx autodoc gen tools properly pick up and format the optional config params from the docstring.

We could then add a check after necessary config to make sure and params in the DAG node config are in the set of the necessary config and optional config params, and return an error noting which params that were specified in the DAG config file are not used by the node.

@briangrahamww briangrahamww added enhancement New feature or request good first issue Good for newcomers labels Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant