Improve xtrigger validation #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Integration test failures unrelated - cylc#5977 |
MetRonnie
force-pushed
the
xtrig
branch
2 times, most recently
from
ebff083
to
51438cf
Compare
MetRonnie
commented
Feb 19, 2024
Comment on lines
+348
to
+350
| bound_args.apply_defaults() | ||
| try: | ||
| xtrig_validate_func(bound_args.arguments) |
There was a problem hiding this comment.
With this approach, people writing xtrigger validate functions don't have to worry about whether an argument is positional and/or keyword (the original xrandom.validate example was flawed because it didn't account both cases under the previous system)
wxtim
added a commit
that referenced
this pull request
Feb 28, 2024
* Xtrigger function arg validation. * Add integration tests for xtrigger validation, which provides simple examples for each of the built in xtriggers. - Xrandom validate function - Init test xrandom validate function - Add unit tests for validation of built in xtriggers - Automatically validate xtrigger function signature --------- Co-authored-by: Hilary James Oliver <[email protected]> * Apply suggestions from code review Co-authored-by: Ronnie Dutta <[email protected]> * fix flake8 * Improve xtrigger validation (#60) * Improve xtrigger validation * wall_clock: use placeholder function for signature validation & autodocs * Fix docstring for autodoc [skip ci] --------- Co-authored-by: Hilary Oliver <[email protected]> Co-authored-by: Ronnie Dutta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement for cylc#5955