Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS type definitions #174

Open
Istar-Eldritch opened this issue Jun 3, 2017 · 1 comment
Open

TS type definitions #174

Istar-Eldritch opened this issue Jun 3, 2017 · 1 comment

Comments

@Istar-Eldritch
Copy link

Istar-Eldritch commented Jun 3, 2017

I would like to add the typescript type definitions to x-tag and I was wondering if you would accept a PR in this repo or if I would have to create them in DefinitelyTyped.

They clearly state that if possible the definitions should live with the original code:

If you are the library author, or can make a pull request to the library, bundle types instead of publishing to DefinitelyTyped.

So, would you accept a PR here?
Also let me know if you need more context of why this is useful.

@joao-arvins
Copy link
Contributor

+1 for the typescript type definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants