Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is tabselected necassary? #6

Open
ghost opened this issue May 28, 2018 · 1 comment
Open

is tabselected necassary? #6

ghost opened this issue May 28, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented May 28, 2018

tabselected isn't defined in the registration object in V1.

if (fireSelected) xtag.fireEvent(tabbox, 'tabselected', {
  detail: {
    currentTab: tab,
    currentPanel: panel,
    previousTab: previous[0],
    previousPanel: previous[1]
  }
} );

I was wondering if you understood this line, and why it was added I think it would have been good if it were completed.

@ghost
Copy link
Author

ghost commented May 29, 2018

I'm going to go comment it out but keep it for further development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants