diff --git a/README.md b/README.md index c14e3e96..8b846948 100644 --- a/README.md +++ b/README.md @@ -1,19 +1,22 @@ ->**NOTE:** ->This is a modified build of rcloneExplorer because of little activity in the parent repo. For the parent repository, see [kaczmarkiewiczp/rcloneExplorer](https://github.com/kaczmarkiewiczp/rcloneExplorer). -> ->If you encounter an issue with a [version published here](https://github.com/x0b/rcloneExplorer/releases), [open an issue here](https://github.com/x0b/rcloneExplorer/issues/new). - - # RcloneExplorer [![license: GPL v3](https://img.shields.io/badge/License-GPLv3-blue.svg)](https://github.com/x0b/rcloneExplorer/blob/master/LICENSE) [![Github Releases](https://img.shields.io/github/downloads/x0b/rcloneExplorer/total.svg)](https://github.com/x0b/rcloneExplorer/releases) [![GitHub release](https://img.shields.io/github/v/release/x0b/rcloneExplorer?include_prereleases)](https://github.com/x0b/rcloneExplorer/releases/latest) rclone explorer for Android +>**Note:** +>This is a modified build of rcloneExplorer because of little activity in the parent repo. For the parent repository, see [kaczmarkiewiczp/rcloneExplorer](https://github.com/kaczmarkiewiczp/rcloneExplorer). +> +>If you encounter an issue with a [version published here](https://github.com/x0b/rcloneExplorer/releases), [open an issue here](https://github.com/x0b/rcloneExplorer/issues/new). + +## SECURITY NOTICE +If you are running rcloneExplorer **1.3.5** to **1.8.2**, or AIS-synchro make sure that "Show thumbnails" in ```Settings``` > ```General``` is **disabled** and update to the latest version. If you have not enabled thumbnails, you are not affected. +More details in [Security Notice 201901: Remote contents readable from local network when browsing any remote with thumbnails enabled](https://github.com/x0b/rcloneExplorer/wiki/Security-Notice-201901-Remote-contents-readable-from-local-network-when-browsing-any-remote-with-thumbnails-enabled). + Features -------- - File Management - List and view files - - Dowload and upload files + - Download and upload files - Move, rename, and delete files and folders - Streaming & Integration - Streaming media files @@ -44,6 +47,7 @@ Note that these plans are subject to change and might not materialize completely - Fix: Crash on LoadingDialog (#7) - Fix: Crash on Android 5.1.1 for remotes with time zones (#10) - Fix: Crash in hide remotes dialog (#13) + - Fix: Security issue when using thumbnails (#18) #### Next Version - New SAF implementation for much faster directory access diff --git a/app/lib/x86_64/librclone.so b/app/lib/x86_64/librclone.so deleted file mode 100644 index 2f8e550f..00000000 Binary files a/app/lib/x86_64/librclone.so and /dev/null differ diff --git a/app/src/androidTest/java/ca/pkay/rcloneexplorer/ExampleInstrumentedTest.java b/app/src/androidTest/java/ca/pkay/rcloneexplorer/ExampleInstrumentedTest.java deleted file mode 100644 index d654547c..00000000 --- a/app/src/androidTest/java/ca/pkay/rcloneexplorer/ExampleInstrumentedTest.java +++ /dev/null @@ -1,26 +0,0 @@ -package ca.pkay.rcloneexplorer; - -import android.content.Context; -import android.support.test.InstrumentationRegistry; -import android.support.test.runner.AndroidJUnit4; - -import org.junit.Test; -import org.junit.runner.RunWith; - -import static org.junit.Assert.*; - -/** - * Instrumented test, which will execute on an Android device. - * - * @see Testing documentation - */ -@RunWith(AndroidJUnit4.class) -public class ExampleInstrumentedTest { - @Test - public void useAppContext() throws Exception { - // Context of the app under test. - Context appContext = InstrumentationRegistry.getTargetContext(); - - assertEquals("ca.pkay.rcloneexplorer", appContext.getPackageName()); - } -} diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 77cbd9de..08b23a40 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -43,11 +43,6 @@ - - - - - diff --git a/app/src/main/assets/changelog.md b/app/src/main/assets/changelog.md index be453205..67f93ef1 100644 --- a/app/src/main/assets/changelog.md +++ b/app/src/main/assets/changelog.md @@ -6,7 +6,7 @@ * **Fix:** Crash on LoadingDialog * **Fix:** Crash on Android 5.1.1 for remotes with time zones * **Fix:** Crash in hide remotes dialog - +* **Fix:** Security issue when using thumbnails (details see wiki) *** ### 1.8.2 diff --git a/app/src/main/java/ca/pkay/rcloneexplorer/Fragments/RemotesFragment.java b/app/src/main/java/ca/pkay/rcloneexplorer/Fragments/RemotesFragment.java index e2630daa..65601a4c 100644 --- a/app/src/main/java/ca/pkay/rcloneexplorer/Fragments/RemotesFragment.java +++ b/app/src/main/java/ca/pkay/rcloneexplorer/Fragments/RemotesFragment.java @@ -295,7 +295,9 @@ public boolean onMenuItemClick(MenuItem item) { private void refreshRemotes() { remotes = filterRemotes(); - recyclerViewAdapter.newData(remotes); + if (null != recyclerViewAdapter) { + recyclerViewAdapter.newData(remotes); + } } private List filterRemotes() { diff --git a/app/src/main/java/ca/pkay/rcloneexplorer/Services/FirebaseIdService.java b/app/src/main/java/ca/pkay/rcloneexplorer/Services/FirebaseIdService.java deleted file mode 100644 index be81be79..00000000 --- a/app/src/main/java/ca/pkay/rcloneexplorer/Services/FirebaseIdService.java +++ /dev/null @@ -1,6 +0,0 @@ -package ca.pkay.rcloneexplorer.Services; - -import com.google.firebase.iid.FirebaseInstanceIdService; - -public class FirebaseIdService extends FirebaseInstanceIdService { -}