Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix SelectedItem in Picker set to null when bound ItemsSource raises CollectionChanged reset event (#2032) #12177

Closed
wants to merge 1 commit into from

Conversation

ajphall
Copy link

@ajphall ajphall commented Sep 18, 2020

Description of Change

Fixes SelectedItem in Picker set to null when bound ItemsSource raises CollectionChanged reset event by storing the previously selected item before refreshing the picker items. After the refresh the previously selected item attempts to be reselected.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Unit test added as part of the PR.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@dnfadmin
Copy link

dnfadmin commented Sep 18, 2020

CLA assistant check
All CLA requirements met.

@jfversluis
Copy link
Member

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!

@jfversluis jfversluis closed this Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants