Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

WebChromeClient.FileChooserParams.ParseResult support multiple files #15341

Closed
BobbyShoe opened this issue Apr 29, 2022 · 4 comments
Closed

WebChromeClient.FileChooserParams.ParseResult support multiple files #15341

BobbyShoe opened this issue Apr 29, 2022 · 4 comments
Labels
s/unverified New report that has yet to be verified t/bug 🐛

Comments

@BobbyShoe
Copy link

Description

When trying to upload files from a WebView using an HTML input file field the WebChromeClient.FileChooserParams.ParseResult method returns null when multiple files are selected. It does work with a single file.

Steps to Reproduce

This article nicely outlines all of the steps necessary to make the File selector appear when a input file is clicked on a web page within a WebView on Android
https://localcoder.org/uploading-files-using-a-webview-in-xamarin-android-app

This does work for single file selection.

To attempt to select multiple I added this Extra information in the OnShowFileChooser method, just before the call to start the activity.
chooserIntent.PutExtra(Intent.ExtraAllowMultiple, true);

The file selection Activity does allow for multiple files to be selected. However on the callback the WebChromeClient.FileChooserParams.ParseResult method does not properly parse the multi-selection and returns null.

  1. Load an HTML Page with a file upload control.
  2. Select multiple files
  3. Once selected, no files are reported as selected.

Expected Behavior

Multiple files should be able to be selected.

Actual Behavior

Multiple file selection does not work.

Basic Information

  • Version with issue: Xamarin.Forms 5.0.0.1931; Xamarin.Forms.Platform.Android 2.0.0.0
  • Last known good version: none
  • Platform Target Frameworks:
    • iOS: Works on IOS without any special code.
    • Android: 11.0
    • UWP: NA
  • Android Support Library / AndroidX Version:
  • NuGet Packages:
  • Affected Devices: All

Environment

Show/Hide Visual Studio info
Microsoft Visual Studio Enterprise 2019
Version 16.11.7
VisualStudio.16.Release/16.11.7+31911.196
Microsoft .NET Framework
Version 4.8.04084

Installed Version: Enterprise

Visual C++ 2019   00435-60000-00000-AA084
Microsoft Visual C++ 2019

ADL Tools Service Provider   1.0
This package contains services used by Data Lake tools

ASA Service Provider   1.0

ASP.NET and Web Tools 2019   16.11.94.52318
ASP.NET and Web Tools 2019

ASP.NET Web Frameworks and Tools 2019   16.11.94.52318
For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0   16.11.94.52318
Azure App Service Tools v3.0.0

Azure Data Lake Node   1.0
This package contains the Data Lake integration nodes for Server Explorer.

Azure Data Lake Tools for Visual Studio   2.6.1000.0
Microsoft Azure Data Lake Tools for Visual Studio

Azure Functions and Web Jobs Tools   16.11.94.52318
Azure Functions and Web Jobs Tools

Azure Stream Analytics Tools for Visual Studio   2.6.1000.0
Microsoft Azure Stream Analytics Tools for Visual Studio

C# Tools   3.11.0-4.21403.6+ae1fff344d46976624e68ae17164e0607ab68b10
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Debugging Tools for Windows   10.0.19030.1000
Integrates the Windows Debugger functionality (http://go.microsoft.com/fwlink/?linkid=223405) in Visual Studio.

Extensibility Message Bus   1.2.6 (master@34d6af2)
Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

Fabric.DiagnosticEvents   1.0
Fabric Diagnostic Events

Intel Libraries for oneAPI   Package ID: w_oneAPI_2021.3.0.306
Intel Libraries for oneAPI – toolkit version: 2021.3.0, extension version 21.1.0.16, Package ID: w_oneAPI_2021.3.0.306, Copyright © 2019-2021 Intel Corporation. All rights reserved.
* Other names and brands may be claimed as the property of others.

Intel® Advisor 2021.3   609871
Intel® Advisor 2021.3, (build 609871), Copyright © 2009-2021 Intel Corporation. All rights reserved.

Intel® C++ Compiler   Package ID: w_oneAPI_2021.3.0.306
Intel® C++ Compiler – toolkit version: 2021.3.0, extension version 21.0.16, Package ID: w_oneAPI_2021.3.0.306, Copyright © 2002-2021 Intel Corporation. All rights reserved.
* Other names and brands may be claimed as the property of others.

Intel® Distribution for GDB*   1.0
Provides debugging capabilities for compute shaders running on the Intel GPU.

Intel® oneAPI DPC++ Compiler   Package ID: w_oneAPI_2021.3.0.306
Intel® oneAPI DPC++ Compiler – toolkit version: 2021.3.0, extension version 21.1.0.16, Package ID: w_oneAPI_2021.3.0.306, Copyright © 2019-2021 Intel Corporation. All rights reserved.
* Other names and brands may be claimed as the property of others.

Intel® oneAPI Menu & Samples   1.1.410
Intel® oneAPI Visual Studio Menu & Samples Extension

Intel® VTune™ Profiler 2021   618064
Intel® VTune™ Profiler 2021, (build 618064),  Copyright © 2009-2021 Intel Corporation. All rights reserved.

IntelliCode Extension   1.0
IntelliCode Visual Studio Extension Detailed Info

Microsoft Azure HDInsight Azure Node   2.6.1000.0
HDInsight Node under Azure Node

Microsoft Azure Hive Query Language Service   2.6.1000.0
Language service for Hive query

Microsoft Azure Service Fabric Tools for Visual Studio   16.10
Microsoft Azure Service Fabric Tools for Visual Studio

Microsoft Azure Stream Analytics Language Service   2.6.1000.0
Language service for Azure Stream Analytics

Microsoft Azure Stream Analytics Node   1.0
Azure Stream Analytics Node under Azure Node

Microsoft Azure Tools for Visual Studio   2.9
Support for Azure Cloud Services projects

Microsoft Continuous Delivery Tools for Visual Studio   0.4
Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE.

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft Library Manager   2.1.113+g422d40002e.RR
Install client-side libraries easily to any web project

Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards

Microsoft Visual Studio Tools for Containers   1.2
Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.

Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package

Mono Debugging for Visual Studio   16.10.15 (552afdf)
Support for debugging Mono processes with Visual Studio.

NuGet Package Manager   5.11.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info

Razor (ASP.NET Core)   16.1.0.2122504+13c05c96ea6bdbe550bd88b0bf6cdddf8cde1725
Provides languages services for ASP.NET Core Razor.

Snapshot Debugging Extension   1.0
Snapshot Debugging Visual Studio Extension Detailed Info

SQL Server Data Tools   16.0.62111.11070
Microsoft SQL Server Data Tools

Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.

Test Adapter for Google Test   1.0
Enables Visual Studio's testing tools with unit tests written for Google Test.  The use terms and Third Party Notices are available in the extension installation directory.

ToolWindowHostedEditor   1.0
Hosting json editor into a tool window

TypeScript Tools   16.0.30526.2002
TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools   3.11.0-4.21403.6+ae1fff344d46976624e68ae17164e0607ab68b10
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools   16.11.0-beta.21514.6+b6c2c4f53ea3a08fa603ea93d6d2f808a62a21d1
Microsoft Visual F# Tools

Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Container Tools Extensions   1.0
View, manage, and diagnose containers within Visual Studio.

Visual Studio Tools for CMake   1.0
Visual Studio Tools for CMake

Visual Studio Tools for Containers   1.0
Visual Studio Tools for Containers

Visual Studio Tools for Kubernetes   1.0
Visual Studio Tools for Kubernetes

VisualStudio.DeviceLog   1.0
Information about my package

VisualStudio.Foo   1.0
Information about my package

VisualStudio.Mac   1.0
Mac Extension for Visual Studio

Windows Driver Kit   10.0.19030.1000
Headers, libraries, and tools needed to develop, debug, and test Windows drivers (msdn.microsoft.com/en-us/windows/hardware/gg487428.aspx)

WiX Toolset Visual Studio Extension   1.0.0.18
WiX Toolset Visual Studio Extension version 1.0.0.18
Copyright (c) .NET Foundation and contributors. All rights reserved.

Xamarin   16.11.000.197 (d16-11@6934992)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer   16.11.0.47 (remotes/origin/d16-11@e0d612363)
Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin Templates   16.10.5 (355b57a)
Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.

Xamarin.Android SDK   12.0.0.3 (d16-11/f0e3c2d)
Xamarin.Android Reference Assemblies and MSBuild support.
    Mono: c633fe9
    Java.Interop: xamarin/java.interop/d16-11@476bb5b
    ProGuard: Guardsquare/proguard/v7.0.1@912d149
    SQLite: xamarin/sqlite/3.35.4@85460d3
    Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-11@87af37b


Xamarin.iOS and Xamarin.Mac SDK   15.2.0.17 (738fde344)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

Workaround

Nothing simple.

@BobbyShoe BobbyShoe added s/unverified New report that has yet to be verified t/bug 🐛 labels Apr 29, 2022
@BobbyShoe
Copy link
Author

For any other poor soul out there struggling with this, I will post an answer to my own question. So apparently when multiple items are selected for upload the returned intent data has information in the ClipData property instead of the Data property. From the examples I posted earlier, you can change the OnActivityResult function, implement the following instead of just calling WebChromeClient.FileChooserParams.ParseResult to get the returned value. I left all of the fully qualified names of everything below for clarity.

Java.Lang.Object? returnedValue;
if (data.ClipData != null)
{
List<Android.Net.Uri> androidUris = new List<Android.Net.Uri>();
for (int i = 0; i < data.ClipData.ItemCount; i++)
{
androidUris.Add(data.ClipData.GetItemAt(i).Uri);
}

returnedValue = Java.Lang.Reflect.Array.FromArray<Android.Net.Uri>(androidUris.ToArray());

}
else
{
returnedValue = WebChromeClient.FileChooserParams.ParseResult((int)resultCode, data);
}

@av325
Copy link

av325 commented Oct 4, 2022

i am a poor soul and you dont alone.if you choose one file the data property is not null and if choose multiple clipData is not null

@jikpas0
Copy link

jikpas0 commented Mar 15, 2023

Hi BobbyShoe,

I managed to get a returned value from clipdata but I am clueless as to what to do next, can you assist

@ghost
Copy link

ghost commented Jul 31, 2023

This is ridiculous that this API works this way to this day. Here's a Kotlin version

val data: Intent? = result.data
val returnedValue: Array<Uri>? = if(result.resultCode !== Activity.RESULT_OK) {
  null
} else if (data?.clipData != null) {
  // The files are in data.clipData if the user selected multiple files
  // https://github.com/xamarin/Xamarin.Forms/issues/15341
  (0 until(data.clipData!!.itemCount)).map { data.clipData!!.getItemAt(it).uri }.toTypedArray()
} else {
  WebChromeClient.FileChooserParams.parseResult(result.resultCode, data)
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
s/unverified New report that has yet to be verified t/bug 🐛
Projects
None yet
Development

No branches or pull requests

3 participants