-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Expo v 43 #162
Comments
I tried "expo install rn-pdf-reader-js" and it works fine. |
Thanks for your reply, I've tried it again with new app but it didn't work. Here my steps:
Log:
I'm using a Ubuntu 20 if it makes any difference. |
Same thing for me... any news ?
|
its simple you all miss this part, tested on expo 43, 44 all works without any problem 👉Install react-native-webview on your own! yarn add react-native-webview expo install expo-constants expo-file-system |
So you using expo, then you should also using yarn ( cuz expo using yarn ) combining 2 package managers is bad idea, why ? Every pckage managers handles things different Tested With yarn on expo 43 and 44 and works without any problem, just few warrnings but it works issue here is NPM and "peerDependencies" with "expo" value ">= 33.0.x < 41.0.x" but works with "yarn" |
that does the trick. |
Hmm how can you use it on Ubuntu? I have only Ubuntu. |
but there is problem when you biuld your project with EAS so u can use your own solution if u using just Read ability install webview <WebView
source={{uri: Platform.OS === 'android' ? `https://docs.google.com/viewer?url=${documentData.url}` : documentData.url}}
//source={{uri: Platform.OS === 'android' ? `https://drive.google.com/viewerng/viewer?embedded=true&url=${documentData.url}` : documentData.url}}
onError={(e) => {
console.log('PDF e - ' + e);
}}
allowFileAccess={Platform.select({android: true, ios: false})}
allowFileAccessFromFileURLs={Platform.select({android: true, ios: false})}
allowUniversalAccessFromFileURLs={Platform.select({android: true, ios: false})}
// scalesPageToFit={Platform.select({android: false})}
mixedContentMode={Platform.select({android: 'always', ios: undefined})}
sharedCookiesEnabled={false}
/> |
Any updates on this one? Ideally this shouldn't be contingent on switching package managers. This clearly isn't supporting Expo SDK's from 41+ because of it's peer dependency: |
It would be nice if a maintainer just approved and merged the pull request that someone submitted to update the versions of the peer dependencies, then it should work for yarn AND npm. |
how to used webview to show base64 string |
Is this repo still maintained? |
Solution anyone? |
@faisal07m I managed to bypass the rn-pdf-reader-js entirely and used the google docs pdf preview function with a WebView.
It provided enough functionality for my usage. |
install with yarn and it should work |
We are just using the --legacy-peer-deps flag when npm install |
Issue Description
I'm trying to install the pdf reader using
npm install rn-pdf-reader-js
but got the error that dependencies cannot be resolved:Steps to Reproduce / Code Snippets
npm install rn-pdf-reader-js
The text was updated successfully, but these errors were encountered: