Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The local mute plugin #10

Open
Wazarr94 opened this issue Jul 20, 2019 · 2 comments
Open

The local mute plugin #10

Wazarr94 opened this issue Jul 20, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Wazarr94
Copy link

Hi, i've used local mute for the first time to mute a not-so-bright guy, and noticed that if the muted guy talks, it can sometimes leave a space in the chat:

image

Since the haxball chat is gonna get refreshed every time, why not hiding it and making the copy that would take into account those mutes & wouldn't suffer from those spaces.

Also, the big mute button in the chat should be setting all players to muted, so we could be able to unmute the few players we wanna be able to check the messages. This would be extremely useful in Real Soccer for instance where we could mute everyone but the referee.

@Wazarr94
Copy link
Author

Also, you should not be able to mute yourself I think

@xenonsb xenonsb added the enhancement New feature or request label Oct 23, 2019
@xenonsb
Copy link
Owner

xenonsb commented Oct 23, 2019

iirc, muting yourself doesn't work - but the button is there as kind of a bug.

I debated between keeping the chat space vs. deleting it and opted for keeping it - in case anyone wants to go back and kinda look for it.

For the big mute + unmute, I'll have to rethink the logic a bit, since new players joining may cause some added complexities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants