Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmented controls have wrong color for dark theme #351

Open
scholtzan opened this issue Nov 15, 2018 · 6 comments
Open

Segmented controls have wrong color for dark theme #351

scholtzan opened this issue Nov 15, 2018 · 6 comments

Comments

@scholtzan
Copy link
Member

When using a dark theme, the segmented controls in the find menu look much darker than the other buttons:

screenshot 2018-11-15 at 15 06 06

@scholtzan
Copy link
Member Author

When changing "Appearance" for the view in Find View Controller from "Inherited" to "Dark Mode" then it is rendered correctly. However, this will break rendering the search bar for bright themes.

@sharaththegeek
Copy link

Were any changes made to the UI after the opening of this issue? When I try to use a dark theme, I find that the find menu is still using a normal theme!! The inconsistency in the colours is very unsettling.

screenshot 2019-02-06 at 12 07 22 am

@scholtzan
Copy link
Member Author

Mmh, that looks like it's a bug. It should change to the dark theme...

@ryanbloom
Copy link
Contributor

@sharaththegeek The find bar only changes color if you open the config file and set unified_titlebar = true.

@sharaththegeek
Copy link

@ryanbloom Thanks! I hadn't set that in the config file. Works now!
Wouldn't it be better if it were set to true by default?

@jansol
Copy link
Contributor

jansol commented Feb 6, 2019

That would be inconsistent with the rest of the system. A better default would be reviving #287 and following the system setting on dark vs light mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@scholtzan @jansol @nangtrongvuon @ryanbloom @sharaththegeek and others