Change default find highlight color #470
Labels
Comments
mohanio
pushed a commit
to mohanio/xi-mac
that referenced
this issue
Oct 19, 2019
Issue: Find highlight color defaults to red color instead it should use system's default find highlight color(NSColor.findHighlightColor) Fix: * Theme has new static variable representing default find highlight color * Other find highlight colors are generated from the hue of default find highlight color * Find highlight color specified by xi-editor on theme_changed event is ignored
|
@cmyr , @nangtrongvuon added a fix for this here #481 |
|
cool, thanks! edit: will need to think about this a bit, but will give it a proper look monday or tuesday. |
7 tasks
mohanio
pushed a commit
to mohanio/xi-mac
that referenced
this issue
Oct 21, 2019
Issue: xi-editor#470 Find highlight color defaults to red color instead it should use system's default find highlight color(NSColor.findHighlightColor) Fix: * Theme has new static variable representing default find highlight color * Other find highlight colors are generated from the hue of default find highlight color * Find highlight color specified by xi-editor on theme_changed event is ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently find highlights are red by default. We should default to
NSColor.findHighlightColoror something? There may also be a color defined in the theme that we can use. (The motivation for not using the colors in the theme is that we support multiple 'find groups' with different colors, and want these to be distinct, but I think we should default to an appropriate color for the first group.The text was updated successfully, but these errors were encountered: