Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The creating of normal binary releases to avoid third-party developer bugs #1327

Closed
GD-fix opened this issue Dec 16, 2023 · 6 comments
Closed

Comments

@GD-fix
Copy link
Contributor

GD-fix commented Dec 16, 2023

Describe the bug
GD-ng doesn't support any dictionaries path on partition containing Root ("/") even if there is only a symbolic link to folder on another partition. So, in case (of course, unusual) of only one partition using there will not be able to add any dictionary in GD-ng at all. This issue was labelled as "Flatpak", nevertheless Flatpak itself supports paths on partition containing Root, because GD-ng runs from it...

To Reproduce
Steps to reproduce the behaviour(the form lacks the letter "u"):
see link above.

Expected behaviour(--//--)
The compiling of usual binaries with statically linked libraries (for releases only and links to them in releases only, not how is now to Flatpak release in every pre-release). It avoids the need of root privileges for users too.
You may consult with huge number of developers here about how to make it (for example, with author of this binaries: it will be easy for You to find a common language with him, I think; but to make more simple binaries, like this)

OS and software versions

  • OS: OpenSUSE Tumbleweed
  • Version up to date

Additional context
Thanks in advance

@GD-fix
Copy link
Contributor Author

GD-fix commented Dec 23, 2023

Last repository version (not a Flatpak) doesn't find dictionaries too...
I apologize for the disinformation. The GoldenDict-ng usual (rpm repository) and Flatpak versions have the same application launch icons names and descriptions both. I had rename the one on panel (Flatpak) and I thought, that the second one in applications menu favourites was of usual (repository) version. But it was also of the Flatpak version...

The last repository version finds all dictionaries. But it crushes (without any error on console output) in attempt to open any article and doesn't support the ZIM dictionaries.
Official repository version doesn't crush in mentioned case, but crushes when saving files (for example, pressing of the "Export" button in a Dictionary Headings window or choosing "Keep the image..." in the drawing context menu of the dictionary article) in case of the connected dictionaries large number - ~10^3 or more with the output error: *** bit out of range 0 - FD_SETSIZE on fd_set ***: terminated.
This version doesn't crush in both cases.
This version doesn't crush in both cases.
The Flatpak version (when the dictionaries were added directly from non-Root partition) how the newest repository version crushes only in first case, but supports the ZIM dictionaries.

@xiaoyifang
Copy link
Owner

What is the the exact version ?

@GD-fix
Copy link
Contributor Author

GD-fix commented Jan 20, 2024

The Flatpak version, that I launched now again, in Discover is as 23.12.23 and in "About the program" is as 23.12.07.b0086d5 at 2023-12-23T04:18:13. It crushed right now in mentioned manner and had the empty history journal...
The last repository version in Program manager is as 07.12.23 and in "About the program" is as 23.12.07. on Sat Jan 20 05:05:06 2024. It crushed right now in mentioned manner, but had the non-empty history journal...

@GD-fix
Copy link
Contributor Author

GD-fix commented May 25, 2024

The problem with crush was solved, but with paths in Flatpak - didn't.
What about normal binary releases for GNU/Linux too?

@GD-fix
Copy link
Contributor Author

GD-fix commented Jun 1, 2024

The problem with paths in Flatpak was solved.
But I don't close this issue, because for example in my case (with almost the same OpenSUSE Tumbleweed OS versions on stand alone PC and PC with Internet) the copying of Flatpak (/var/lib/flatpak/) works, in case of more different systems - may not.

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Jun 16, 2024

Creating such binary requires dealing with differences between different distros and their different versions. It is a time sucking black hole that never ends.

Feel free to try to restore the AppImage build, deleted code is here

- name: Build AppImage
run: |
# for /usr/lib/qt6/plugins/platforminputcontexts/libfcitx5platforminputcontextplugin.so
sudo apt-get install extra-cmake-modules libxkbcommon-dev libxcb1 libxcb-cursor0
git clone --single-branch --depth 1 https://github.com/fcitx/fcitx5-qt.git
cd fcitx5-qt
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DENABLE_QT4=OFF -DENABLE_QT5=OFF -DENABLE_QT6=ON -DBUILD_ONLY_PLUGIN=ON
cmake --build build
sudo cmake --install ./build
cd ..
wget -c -nv "https://github.com/linuxdeploy/linuxdeploy-plugin-qt/releases/download/continuous/linuxdeploy-plugin-qt-x86_64.AppImage"
chmod a+x linuxdeploy-plugin-qt-x86_64.AppImage
wget -c -nv "https://github.com/linuxdeploy/linuxdeploy/releases/download/continuous/linuxdeploy-x86_64.AppImage"
chmod a+x linuxdeploy-x86_64.AppImage
./linuxdeploy-x86_64.AppImage --appdir appdir --output appimage --plugin qt -i redist/icons/goldendict.png -d redist/io.github.xiaoyifang.goldendict_ng.desktop

@shenlebantongying shenlebantongying closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2024
Repository owner deleted a comment from GD-fix Jun 22, 2024
Repository owner locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants