Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: unify dictionaryid #1446

Closed
wants to merge 1 commit into from
Closed

Conversation

xiaoyifang
Copy link
Owner

@xiaoyifang xiaoyifang commented Mar 27, 2024

benefit :
you can move your dictionary files into other folders and have no need to reindex the dictionary again.

drawback:
If you have two versions of the same dictionary , only the first one got indexed.

@xiaoyifang xiaoyifang force-pushed the opt/unify-dictionaryid branch from 8137804 to 0b5f64d Compare March 27, 2024 09:57
Copy link

@shenlebantongying shenlebantongying added the vNext Improvments and optimizations that need incompatible changes. label May 25, 2024
@GD-fix
Copy link
Contributor

GD-fix commented Jun 1, 2024

drawback:
If you have two versions of the same dictionary , only the first one got indexed.

What "two versions" means here: the same content and name dictionary files on two different locations, only the same name dictionary files on two different locations, only the same content dictionary files regardless of their locations, or the same name dictionaries regardless of their content, files names and files locations?

@xiaoyifang
Copy link
Owner Author

What "two versions" means here: the same content and name dictionary files on two different locations, only the same name dictionary files on two different locations, only the same content dictionary files regardless of their locations, or the same name dictionaries regardless of their content, files names and files locations?

the dictionaryid only cares about the filenames ,so the answer should be " or the same name dictionaries regardless of their content"

@GD-fix
Copy link
Contributor

GD-fix commented Jun 1, 2024

If "the dictionaryid only cares about the filenames" than the answer about "two versions of the same dictionary" must be "only the same name dictionary files on two different locations". Am I right?

@GD-fix
Copy link
Contributor

GD-fix commented Jun 8, 2024

Is it possible to append to Preferences the option of "moving dictionary files into other folders and have no need to reindex", of course with ATTENTION! about mentioned drawback and full reindex of all dictionaries (and this one option with appropriate ATTENTION! too)?

@xiaoyifang
Copy link
Owner Author

"moving dictionary files into other folders and have no need to reindex", of course with ATTENTION!

I do not think we have time for this. The above function will only be used one time in life.

@GD-fix

This comment was marked as off-topic.

@GD-fix
Copy link
Contributor

GD-fix commented Jun 22, 2024

If You have such time pressure, then lay out 2 release variants please...

@shenlebantongying
Copy link
Collaborator

Massively breaking existing installations and creating confusion is not a reasonable action.

I don't think we will do this until we find a better solution or put significant effort writing on a config migrator and clarify that we stop keeping compatibility with the original GD.

Even the change in this PR is questionable.

For example, why do we still use md5 if we're ever going to change it? If we use something that can be decoded back to the original content, it will make debugging much easier.

Also, if the meaning of config changed, then it should be put somewhere else, instead of modifying in place.

@xiaoyifang
Copy link
Owner Author

For example, why do we still use md5 if we're ever going to change it? If we use something that can be decoded back to the original content, it will make debugging much easier.

md5 is signature alogrithm., while the other is encryption.
Decode is not needed at such place.over-designed.

But it is ok to close this PR.

@GD-fix
Copy link
Contributor

GD-fix commented Jun 29, 2024

Simply a portable binary (with statically linked libraries) version with this dictionary id variant and own config file and index folder...

@xiaoyifang xiaoyifang deleted the opt/unify-dictionaryid branch December 30, 2024 02:09
@xiaoyifang xiaoyifang restored the opt/unify-dictionaryid branch December 30, 2024 02:09
@xiaoyifang xiaoyifang deleted the opt/unify-dictionaryid branch January 10, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vNext Improvments and optimizations that need incompatible changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants