-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: unify dictionaryid #1446
opt: unify dictionaryid #1446
Conversation
8137804
to
0b5f64d
Compare
Quality Gate passedIssues Measures |
What "two versions" means here: the same content and name dictionary files on two different locations, only the same name dictionary files on two different locations, only the same content dictionary files regardless of their locations, or the same name dictionaries regardless of their content, files names and files locations? |
the dictionaryid only cares about the filenames ,so the answer should be " or the same name dictionaries regardless of their content" |
If "the dictionaryid only cares about the filenames" than the answer about "two versions of the same dictionary" must be "only the same name dictionary files on two different locations". Am I right? |
Is it possible to append to Preferences the option of "moving dictionary files into other folders and have no need to reindex", of course with ATTENTION! about mentioned drawback and full reindex of all dictionaries (and this one option with appropriate ATTENTION! too)? |
I do not think we have time for this. The above function will only be used one time in life. |
This comment was marked as off-topic.
This comment was marked as off-topic.
If You have such time pressure, then lay out 2 release variants please... |
Massively breaking existing installations and creating confusion is not a reasonable action. I don't think we will do this until we find a better solution or put significant effort writing on a config migrator and clarify that we stop keeping compatibility with the original GD. Even the change in this PR is questionable. For example, why do we still use md5 if we're ever going to change it? If we use something that can be decoded back to the original content, it will make debugging much easier. Also, if the meaning of config changed, then it should be put somewhere else, instead of modifying in place. |
md5 is signature alogrithm., while the other is encryption. But it is ok to close this PR. |
Simply a portable binary (with statically linked libraries) version with this dictionary id variant and own config file and index folder... |
benefit :
you can move your dictionary files into other folders and have no need to reindex the dictionary again.
drawback:
If you have two versions of the same dictionary , only the first one got indexed.