Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: pet action support #127

Open
xiashtra opened this issue Jun 10, 2024 · 2 comments
Open

Feature request: pet action support #127

xiashtra opened this issue Jun 10, 2024 · 2 comments

Comments

@xiashtra
Copy link
Contributor

The core math functions should support pet damage calculation, and the simulator should support pet actions that occur separately from a player gcd or ogcd.

@xpdota
Copy link
Collaborator

xpdota commented Jun 10, 2024

Is a "pet action that occurs separately from a player gcd or ogcd" like a pet autoattack?

I was thinking of doing it where all player abilities sim out first, then it computes the pet actions purely downstream of that by looking at what pet actions the ability should trigger. The problem is that if the pet action also triggers something to happen that would affect the player, then this approach doesn't work.

@xiashtra
Copy link
Contributor Author

I would talk to the maintainers for SMN, NIN, MCH, AST, DRK and make sure whatever you plan is sufficient to model their jobs. Pets mirror (some) player buffs in real-time, so simulating pet summoning delays and attack delays may be relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants