Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Membership Policies more composable by using bitflags #1095

Open
insipx opened this issue Sep 26, 2024 · 1 comment
Open

Make Membership Policies more composable by using bitflags #1095

insipx opened this issue Sep 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@insipx
Copy link
Contributor

insipx commented Sep 26, 2024 •
edited
Loading

We should be able to compose our membership policies (who is allowed to add/remove/etc) with bitflags. This should make proto simpler & cleaner to define policies in-code.

libxmtp/xmtp_mls/src/groups/group_permissions.rs

Line 604 in 4f529ae

pub enum BasePolicies {

@insipx insipx added enhancement New feature or request good first issue Good for newcomers labels Sep 26, 2024
@neekolas
Copy link
Contributor

Just want to flag that this would be a breaking change for all existing groups

@insipx insipx added on-ice Unsure if still relevant/stale and removed good first issue Good for newcomers on-ice Unsure if still relevant/stale labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
libxmtp
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neekolas @insipx