Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: HTTP error codes are not being passed through to the SDK level #588

Open
bwcDvorak opened this issue Mar 25, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@bwcDvorak
Copy link
Contributor

Describe the bug

Recent testing by @alexrisch uncovered that message sending errors are not currently bubbling up 429's (and other?) errors up to the SDK layer.

As an example, this prevents someone using the SDK from easily detecting the 429's that indicate they're being rate limited.

Expected behavior

429's and other error codes would bubble up so the SDK user can make use of the info.

Steps to reproduce the bug

No response

@bwcDvorak bwcDvorak added the bug Something isn't working label Mar 25, 2024
@neekolas
Copy link
Contributor

There's been a long-standing ask for us to send a JSON response from our WAF when it rate limits you, instead of a string. That would let us get better errors in the JS SDK.

@bwcDvorak bwcDvorak changed the title Bug: Bug: HTTP error codes are not being passed through to the SDK level Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants